You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2020/03/11 02:30:26 UTC

[trafficserver] branch 9.0.x updated: Remove method that does nothing. (#6501)

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new 0c88810  Remove method that does nothing. (#6501)
0c88810 is described below

commit 0c88810436264807fd36284fd7aa61d4c8cac526
Author: David Calavera <da...@gmail.com>
AuthorDate: Tue Mar 10 19:29:47 2020 -0700

    Remove method that does nothing. (#6501)
    
    Long time ago, this method used to do something, but not anymore.
    
    Signed-off-by: David Calavera <da...@gmail.com>
    (cherry picked from commit 51b8e9fe4cbe7183329eefee18f4b101d058d2f8)
---
 include/tscpp/api/Url.h         | 8 --------
 src/tscpp/api/Url.cc            | 5 -----
 src/tscpp/api/utils_internal.cc | 1 -
 3 files changed, 14 deletions(-)

diff --git a/include/tscpp/api/Url.h b/include/tscpp/api/Url.h
index cf4b859..c01b8da 100644
--- a/include/tscpp/api/Url.h
+++ b/include/tscpp/api/Url.h
@@ -124,14 +124,6 @@ public:
    */
   void setPort(const uint16_t);
 
-  /**
-   * This method allows you to reset the url, this will force the Url to fully re-read all cached values.
-   * If this method is used on a Detached Requests' Url object it will completely destroy the values.
-   *
-   * \note This method should rarely be used.
-   */
-  void reset();
-
 private:
   bool isInitialized() const;
   void init(void *hdr_buf, void *url_loc);
diff --git a/src/tscpp/api/Url.cc b/src/tscpp/api/Url.cc
index a8f7144..c8e0430 100644
--- a/src/tscpp/api/Url.cc
+++ b/src/tscpp/api/Url.cc
@@ -63,11 +63,6 @@ bool inline Url::isInitialized() const
   return state_->hdr_buf_ && state_->url_loc_;
 }
 
-void
-Url::reset()
-{
-}
-
 std::string
 Url::getUrlString() const
 {
diff --git a/src/tscpp/api/utils_internal.cc b/src/tscpp/api/utils_internal.cc
index 923c48d..af76669 100644
--- a/src/tscpp/api/utils_internal.cc
+++ b/src/tscpp/api/utils_internal.cc
@@ -61,7 +61,6 @@ handleTransactionEvents(TSCont cont, TSEvent event, void *edata)
   utils::internal::setTransactionEvent(transaction, event);
   switch (event) {
   case TS_EVENT_HTTP_POST_REMAP:
-    transaction.getClientRequest().getUrl().reset();
     // This is here to force a refresh of the cached client request url
     TSMBuffer hdr_buf;
     TSMLoc hdr_loc;