You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/14 03:11:50 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12362: [Migrate][Test] Migrate all UT cases from jUnit 4 to 5 in master, worker, and remote modules

EricGao888 commented on code in PR #12362:
URL: https://github.com/apache/dolphinscheduler/pull/12362#discussion_r995299470


##########
dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumerTest.java:
##########
@@ -37,18 +37,14 @@
 import java.util.Date;
 import java.util.concurrent.TimeUnit;
 
-import org.junit.After;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Ignore;
-import org.junit.Test;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.*;

Review Comment:
   We are supposed to avoid wildcard `*` imports. Usually spotless will detect and block this. I'm not sue why it didn't work here. I will take a look at it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org