[GitHub] [incubator-iceberg] massdosage commented on pull request #935: [WIP] Internal relocated version of Guava

[GitBox <gi...@apache.org>]

massdosage commented on pull request #935:
URL: https://github.com/apache/incubator-iceberg/pull/935#issuecomment-620057221


   @rdblue @rdsr I've just pushed a change that makes the base package for the relocated Guava classes be "com.google.common.shaded" as you suggested. I've only done it for the `iceberg-api` package to get approval on approach before rolling it out to the other subprojects. The plus side is that the import changes are smaller, the down side is that I have had to modify the checkstyle rules banning imports of shaded classes as the package name now triggers those to go off. Let me know what you think for next steps.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org