You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2024/12/14 05:10:08 UTC
[PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
frankvicky opened a new pull request, #18182:
URL: https://github.com/apache/kafka/pull/18182
JIRA: KAFKA-18242
> gradle does not support the `release` in joint compilation (see https://github.com/gradle/gradle/issues/13762)
> hence, we have to add `options.compilerArgs += ["--release", String.valueOf(releaseVersion)]` back to scala compiler
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18182:
URL: https://github.com/apache/kafka/pull/18182#issuecomment-2542844063
@frankvicky all we need to change is Scala compiler, so please add the change to Scala only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #18182:
URL: https://github.com/apache/kafka/pull/18182#issuecomment-2542902758
In `clients` module:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18182:
URL: https://github.com/apache/kafka/pull/18182#issuecomment-2557223750
> We need to make sure the 4.0 branch also has the right major version. Do we need to cherry-pick this to that branch or did we not include the original commit that caused the issue?
Pardon me, but this patch is already included in branch 4.0. Please see [build.gradle line 804](https://github.com/apache/kafka/blob/4.0/build.gradle#L804) for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #18182:
URL: https://github.com/apache/kafka/pull/18182#issuecomment-2542837733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #18182:
URL: https://github.com/apache/kafka/pull/18182#issuecomment-2542843215
Hello @chia7712, @frankvicky , I noticed that this PR changes the behavior of IntelliJ, which might not be something we can accept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18182:
URL: https://github.com/apache/kafka/pull/18182#issuecomment-2543023947
I tested the Java 19+ features on the core module, and IntelliJ now displays accurate error messages.
Additionally, the version of java code in core module is "17"
```
chia7712@fedora:~/project/kafka/core/build/libs$ jar xf kafka_2.13-4.0.0-SNAPSHOT.jar
chia7712@fedora:~/project/kafka/core/build/libs$ javap -verbose kafka/server/QuotaFactory | grep major
major version: 61
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #18182:
URL: https://github.com/apache/kafka/pull/18182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #18182:
URL: https://github.com/apache/kafka/pull/18182#discussion_r1884816840
##########
build.gradle:
##########
@@ -124,7 +124,9 @@ ext {
def releaseVersion = modulesNeedingJava11.any { projectPath == it } ? minClientJavaVersion : minNonClientJavaVersion
options.compilerArgs << "-encoding" << "UTF-8"
- options.release = releaseVersion
+ // Gradle does not support the `release` configuration when performing joint Java-Scala compilation. For more details, refer to https://github.com/gradle/gradle/issues/13762.
Review Comment:
This line is a bit long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18242: The java code in core module is NOT configured with suitable release version [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #18182:
URL: https://github.com/apache/kafka/pull/18182#issuecomment-2557147998
We need to make sure the 4.0 branch also has the right major version. Do we need to cherry-pick this to that branch or did we not include the original commit that caused the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org