You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/20 13:02:25 UTC
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2770: [Improve][e2e]change the jdbc driver scope to provider
hailin0 commented on code in PR #2770:
URL: https://github.com/apache/incubator-seatunnel/pull/2770#discussion_r975333532
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcPhoenixIT.java:
##########
@@ -177,4 +178,10 @@ private void batchInsertData() throws SQLException, ClassNotFoundException {
throw e;
}
}
+
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/flink/seatunnel/plugins/Jdbc/lib && cd /tmp/flink/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
as above
##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-jdbc-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/jdbc/JdbcDmdbIT.java:
##########
@@ -144,4 +145,9 @@ public void testJdbcDmdbSourceAndSink() throws IOException, InterruptedException
assertHasData(SINK_TABLE);
}
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/flink/seatunnel/plugins/Jdbc/lib && cd /tmp/flink/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
Use dir `/tmp/seatunnel/plugins/`?
reference
#2762
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-jdbc-spark-e2e/src/test/java/org/apache/seatunnel/e2e/spark/v2/jdbc/JdbcPhoenixIT.java:
##########
@@ -177,4 +178,10 @@ private void batchInsertData() throws SQLException, ClassNotFoundException {
throw e;
}
}
+
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/spark/seatunnel/plugins/Jdbc/lib && cd /tmp/spark/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
as above
##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-jdbc-spark-e2e/src/test/java/org/apache/seatunnel/e2e/spark/v2/jdbc/JdbcDmdbIT.java:
##########
@@ -148,4 +148,10 @@ public void testDMDBSourceToJdbcSink() throws SQLException, IOException, Interru
assertHasData(SINK_TABLE);
}
+ @Override
+ protected void executeExtraCommands(GenericContainer<?> container) throws IOException, InterruptedException {
+ Container.ExecResult extraCommands = container.execInContainer("bash", "-c", "mkdir -p /tmp/spark/seatunnel/plugins/Jdbc/lib && cd /tmp/spark/seatunnel/plugins/Jdbc/lib && curl -O " + THIRD_PARTY_PLUGINS_URL);
Review Comment:
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org