You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/07 21:04:58 UTC

[GitHub] [superset] philihp opened a new issue, #20646: Edit Chart link has inconsistent behavior

philihp opened a new issue, #20646:
URL: https://github.com/apache/superset/issues/20646

#### How to reproduce the bug

1. In a dashboard, look at a chart
2. Click the vertical ellipsis in the top right
3. Hit "Edit Chart"

### Expected results

The browser navigates to a webpage for editing the chart.

* It should not open a new tab.
* It should not open a new window.

### Actual results

In Chrome, it opens a new tab.

In Safari, nothing happens, because Safari thinks this is a popup.

#### Screenshots

### Environment

(please complete the following information):

- Safari Version 15.3 (17612.4.9.1.5)
- Chrome Version 103.0.5060.114 (Official Build) (arm64)
- Running Preset, which says "Powered by Apache Superset Version: 2022.25.2"

### Checklist

Make sure to follow these steps before submitting your issue - thank you!

- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.

### Additional context

https://www.nngroup.com/articles/new-browser-windows-and-tabs/

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] opus-42 commented on issue #20646: Edit Chart link has inconsistent behavior

Posted by GitBox <gi...@apache.org>.

opus-42 commented on issue #20646:
URL: https://github.com/apache/superset/issues/20646#issuecomment-1251595317

   Hello, 
   
   I am not sure about the current implemented behavior. But I would argue that one would prefer having a new tab, which allow for Dashboard Editor to keep the original Dashboard Page, while editing a chart from the Dashboard Link. 
   
   On Chrome (Version 105.0.5195.125 (Official Build) (x86_64)), there is currently no new tab opening. I have just proposed PR to switch to target a new tab.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on issue #20646: Edit Chart link has inconsistent behavior

Posted by GitBox <gi...@apache.org>.

rusackas commented on issue #20646:
URL: https://github.com/apache/superset/issues/20646#issuecomment-1179296754

   This has been a quagmire for a long time, believe it or not. BUT... there are changes happening right now in making various bits of the application into a Single Page App (SPA) and this little link will be revisited in a new light. In short, I think we can resolve this, but there are some workflows that long-term users are quite used to that we'll have to change expectations/behavior around.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] philihp closed issue #20646: Edit Chart link has inconsistent behavior

Posted by GitBox <gi...@apache.org>.

philihp closed issue #20646: Edit Chart link has inconsistent behavior
URL: https://github.com/apache/superset/issues/20646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] philihp commented on issue #20646: Edit Chart link has inconsistent behavior

Posted by GitBox <gi...@apache.org>.

philihp commented on issue #20646:
URL: https://github.com/apache/superset/issues/20646#issuecomment-1252982527

   Seems this has already been fixed, thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org