[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1065: fix: fix recovery verification bug

[GitBox <gi...@apache.org>]

acelyc111 commented on code in PR #1065:
URL: https://github.com/apache/incubator-pegasus/pull/1065#discussion_r925272307


##########
src/rdsn/src/meta/server_state.h:
##########
@@ -353,6 +353,18 @@ class server_state
                                                   const std::vector<std::string> &keys,
                                                   const std::vector<std::string> &values);
 
+    bool app_info_compatible_equal(const app_info &l, const app_info &r) const
+    {
+        if (l.status != r.status || l.app_type != r.app_type || l.app_name != r.app_name ||

Review Comment:
   Better to add some comments to explain why do this partial fields check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org