You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/30 08:48:46 UTC
[GitHub] [airflow] CastielWong opened a new pull request #13983: Fix the broken template of default_airflow
CastielWong opened a new pull request #13983:
URL: https://github.com/apache/airflow/pull/13983
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
When I copy the "default_airflow" template then try to apply "[dockerrize](https://github.com/jwilder/dockerize)" to render the template yet failed.
It spent me quite a while to figure out what had happened. When I double checked the "airflow.cfg" auto-generated by `airflow db init`, I finally realized the reason why it failed was because of those extra brackets for delims in the template.
So this PR is to fix the issue by removing those extra brackets in the template.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13983: Fix the broken template of default_airflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13983:
URL: https://github.com/apache/airflow/pull/13983#issuecomment-770182194
[The Workflow run](https://github.com/apache/airflow/actions/runs/523029886) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] CastielWong commented on pull request #13983: Fix the broken template of default_airflow
Posted by GitBox <gi...@apache.org>.
CastielWong commented on pull request #13983:
URL: https://github.com/apache/airflow/pull/13983#issuecomment-770296493
Looks like this issue is caused by "pylint", can't fix it without reconfig pre-commit thus close the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] CastielWong closed pull request #13983: Fix the broken template of default_airflow
Posted by GitBox <gi...@apache.org>.
CastielWong closed pull request #13983:
URL: https://github.com/apache/airflow/pull/13983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13983: Fix the broken template of default_airflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13983:
URL: https://github.com/apache/airflow/pull/13983#issuecomment-770188335
[The Workflow run](https://github.com/apache/airflow/actions/runs/523105384) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13983: Fix the broken template of default_airflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13983:
URL: https://github.com/apache/airflow/pull/13983#issuecomment-770289223
[The Workflow run](https://github.com/apache/airflow/actions/runs/524131018) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13983: Fix the broken template of default_airflow
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13983:
URL: https://github.com/apache/airflow/pull/13983#issuecomment-770179367
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13983: Fix the broken template of default_airflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13983:
URL: https://github.com/apache/airflow/pull/13983#issuecomment-770206982
[The Workflow run](https://github.com/apache/airflow/actions/runs/523301004) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org