You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2015/01/09 19:28:54 UTC
Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-9073
https://issues.apache.org/jira/browse/AMBARI-9073
Repository: ambari
Description
-------
Patch is still in preview due to the following known issues:
1) clients do not have START action and thus their version is not updated;
2) there are no reports yet about NAMENODE
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4b915aa
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
Diff: https://reviews.apache.org/r/29771/diff/
Testing
-------
Thanks,
Yurii Shylov
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review67924
-----------------------------------------------------------
Ship it!
Looks good
- Dmitro Lisnichenko
On Jan. 13, 2015, 7:38 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 7:38 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review67927
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 13, 2015, 2:38 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 2:38 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review67934
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 13, 2015, 7:38 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 7:38 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review68050
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 14, 2015, 10:20 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 10:20 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 60f589a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review68049
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 14, 2015, 3:20 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 3:20 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 60f589a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/
-----------------------------------------------------------
(Updated Янв. 14, 2015, 3:20 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Extra NPE check added
Bugs: AMBARI-9073
https://issues.apache.org/jira/browse/AMBARI-9073
Repository: ambari
Description
-------
Patch is still in preview due to the following known issues:
1) clients do not have START action and thus their version is not updated;
2) there are no reports yet about NAMENODE
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 60f589a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
Diff: https://reviews.apache.org/r/29771/diff/
Testing
-------
Thanks,
Yurii Shylov
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review68047
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/29771/#comment112213>
Can't previousVersion still be null here?
- Nate Cole
On Jan. 14, 2015, 9:51 a.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 9:51 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 60f589a
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/
-----------------------------------------------------------
(Updated Янв. 14, 2015, 2:51 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Fix UT failures, add NPE checks
Bugs: AMBARI-9073
https://issues.apache.org/jira/browse/AMBARI-9073
Repository: ambari
Description
-------
Patch is still in preview due to the following known issues:
1) clients do not have START action and thus their version is not updated;
2) there are no reports yet about NAMENODE
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 60f589a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
Diff: https://reviews.apache.org/r/29771/diff/
Testing
-------
Thanks,
Yurii Shylov
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/
-----------------------------------------------------------
(Updated Янв. 13, 2015, 7:38 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Update according to comments
Bugs: AMBARI-9073
https://issues.apache.org/jira/browse/AMBARI-9073
Repository: ambari
Description
-------
Patch is still in preview due to the following known issues:
1) clients do not have START action and thus their version is not updated;
2) there are no reports yet about NAMENODE
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
Diff: https://reviews.apache.org/r/29771/diff/
Testing
-------
Thanks,
Yurii Shylov
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review67484
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
<https://reviews.apache.org/r/29771/#comment111528>
We will still need this check that allHostComponents.size() == upgradedHostComponents.size().
We should not need to calculate nonUpgradedHostComponents.
- Alejandro Fernandez
On Jan. 9, 2015, 6:28 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 6:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4b915aa
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Yurii Shylov <yu...@gmail.com>.
> On Янв. 9, 2015, 6:55 п.п., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java, line 1728
> > <https://reviews.apache.org/r/29771/diff/1/?file=814794#file814794line1728>
> >
> > We should not need to distinguish between masters vs clients. So this if-block should not be needed.
This wasn't resolved yet, please fix it in skope of https://reviews.apache.org/r/29790/
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review67474
-----------------------------------------------------------
On Янв. 13, 2015, 7:38 п.п., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Янв. 13, 2015, 7:38 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3714060
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 29771: Rolling Upgrade - Finalize needs to complete
upgrade states in DB
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29771/#review67474
-----------------------------------------------------------
Thanks for getting this in. This will leave us in a good state to be one step closer to end-to-end happy path.
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/29771/#comment111513>
We should not check the type of command, but only that structuredOut is not empty. Otherwise, the configure commands cannot advertise the version.
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/29771/#comment111514>
Typo in "StructuredOut"
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
<https://reviews.apache.org/r/29771/#comment111519>
Can the recalculate happen after all of the CommandReports on the host have been iterated over? This should improve performance.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
<https://reviews.apache.org/r/29771/#comment111520>
Thank you for removing this.
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
<https://reviews.apache.org/r/29771/#comment111523>
Should also check that the version != UNKNOWN
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
<https://reviews.apache.org/r/29771/#comment111522>
We should not need to distinguish between masters vs clients. So this if-block should not be needed.
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
<https://reviews.apache.org/r/29771/#comment111524>
Instead, check that upgradedHostComponents.size() > 0 and that they all have the same version value.
- Alejandro Fernandez
On Jan. 9, 2015, 6:28 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29771/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 6:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9073
> https://issues.apache.org/jira/browse/AMBARI-9073
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch is still in preview due to the following known issues:
> 1) clients do not have START action and thus their version is not updated;
> 2) there are no reports yet about NAMENODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 11f2c14
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 7894de8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 15411fc
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 74e2371
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b9525a
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 53c8cff
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java e86ca1a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9047b15
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4b915aa
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0e7b9c6
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 0159a11
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 50085f2
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java b89b31c
>
> Diff: https://reviews.apache.org/r/29771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yurii Shylov
>
>