You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/05/23 11:18:33 UTC
[GitHub] storm pull request #2135: Leave checkstyle violation to each module's target...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2135
Leave checkstyle violation to each module's target directory
Because of output log size policy for Travis CI, we can't print violation report to the console. Instead of that, we can just leave violation to the file.
This would help to fix checkstyle violation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm quickfix-log-checkstyle-violation-to-output-file
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2135
----
commit d370c5e7a0da58eb5d2d9cd383a63a6977baf63b
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-05-23T11:14:36Z
Leave checkstyle violation to each module's target directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2135: Leave checkstyle violation to each module's target direct...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2135
Btw I don't like xml representation but when I set output format to plain, checkstyle plugin complains.
`Output format is 'plain', checkstyle:check requires format to be 'xml'`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2135: Leave checkstyle violation to each module's target...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2135: Leave checkstyle violation to each module's target direct...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2135
+1
The check goal doesn't currently support "plain" output, the documentation is wrong. http://svn.apache.org/viewvc/maven/plugins/tags/maven-checkstyle-plugin-2.17/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleViolationCheckMojo.java?view=markup#l556
It's because the plugin writes the checkstyle results to disk, then parses them back up again to figure out if there were any rule violations so it can fail the build. The parsing code only understands XML.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2135: Leave checkstyle violation to each module's target direct...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2135
+1
Although I think this is already happening. As a part of https://github.com/apache/storm/pull/2113 I added in an xslt script to make reading the XML format better (like plain) and a python script to help search through it to help do things like look at violations only for files I touched with this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---