[GitHub] flink pull request #6216: [FLINK-9674][tests] Replace hard-coded sleeps in Q...

[florianschmidt1994 <gi...@git.apache.org>]

Github user florianschmidt1994 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6216#discussion_r199719951
  
    --- Diff: flink-end-to-end-tests/test-scripts/test_queryable_state_restart_tm.sh ---
    @@ -85,20 +90,23 @@ function run_test() {
             exit 1
         fi
     
    -    local current_num_checkpoints=current_num_checkpoints$(get_completed_number_of_checkpoints ${JOB_ID})
    -
         kill_random_taskmanager
     
         latest_snapshot_count=$(cat $FLINK_DIR/log/*out* | grep "on snapshot" | tail -n 1 | awk '{print $4}')
         echo "Latest snapshot count was ${latest_snapshot_count}"
     
    -    sleep 65 # this is a little longer than the heartbeat timeout so that the TM is gone
    +    # wait until the TM loss was detected
    +    wait_for_job_state_transition ${JOB_ID} "RESTARTING" "CREATED"
     
         start_and_wait_for_tm
     
    +    wait_job_running ${JOB_ID}
    +
    +    local current_num_checkpoints="$(get_completed_number_of_checkpoints ${JOB_ID})"
    --- End diff --
    
    Why did you move this from `before killing the TM` to `after having the TM restarted again` ?


---