You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Jiri Daněk (JIRA)" <ji...@apache.org> on 2019/04/15 16:22:00 UTC
[jira] [Commented] (PROTON-2031) CMake files for find_package() in
/lib64/cmake/Proton/ProtonConfig.cmake should log a message
[ https://issues.apache.org/jira/browse/PROTON-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818136#comment-16818136 ]
Jiri Daněk commented on PROTON-2031:
------------------------------------
I am no longer certain whose job is to print such log message.
It seems CMake has mechanism to autogenerate the {{ProtonConfig.cmake}} file without using any templates for it, by just using the {{install(EXPORT) command}}.
> CMake files for find_package() in /lib64/cmake/Proton/ProtonConfig.cmake should log a message
> ---------------------------------------------------------------------------------------------
>
> Key: PROTON-2031
> URL: https://issues.apache.org/jira/browse/PROTON-2031
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.27.0
> Reporter: Jiri Daněk
> Priority: Minor
>
> Currently, Qpid Dispatch does
> {noformat}
> find_package(Proton 0.23 REQUIRED COMPONENTS Core Proactor)
> message(STATUS "Found Proton: ${Proton_LIBRARIES} (found version \"${Proton_VERSION}\")" ){noformat}
> but that {{message()}} should not be necessary. Instead, Proton's {{/lib64/cmake/Proton/ProtonConfig.cmake}} and {{/lib64/cmake/ProtonCpp/ProtonCppConfig.cmake}} files should each be taking care of printing that, unless the {{QUIET}} flag is specified https://cmake.org/cmake/help/v2.8.12/cmake.html#command:find_package
> Adding the message to Proton would mean Dispatch compilation will print the same message twice. I think that is acceptable temporary state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org