You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/24 03:54:08 UTC
[GitHub] [flink] TanYuxin-tyx opened a new pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
TanYuxin-tyx opened a new pull request #18456:
URL: https://github.com/apache/flink/pull/18456
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, different TaskManagers select shuffle data directory in the same order and if there are multiple disks, some disks may stores more data than others which is bad for performance. This patch shuffles the data directories to make it fairer for selection between different TaskManagers, which is good for load balance especially when there are multiple disks.
## Brief change log
- *Shuffle data directories to make directory selection of different TaskManagers fairer.*
## Verifying this change
This change is already covered by existing tests.
This change added tests`NettyShuffleEnvironmentConfigurationTest#testShuffleArray`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977",
"triggerID" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"triggerType" : "PUSH"
}, {
"hash" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021",
"triggerID" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"triggerType" : "PUSH"
}, {
"hash" : "2e2b7be4e3ede352958733f19d58d39636627fa3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30099",
"triggerID" : "2e2b7be4e3ede352958733f19d58d39636627fa3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dafb491becd249f55bef64d9cf5276d692dd75f7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021)
* 2e2b7be4e3ede352958733f19d58d39636627fa3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1020102805
@TanYuxin-tyx Thanks for the contribution. Changes LGTM. Will merge after all tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry closed pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
wsry closed pull request #18456:
URL: https://github.com/apache/flink/pull/18456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977",
"triggerID" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd74a88227edf6a00098a9d651634e009ac3fe9f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977",
"triggerID" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"triggerType" : "PUSH"
}, {
"hash" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021",
"triggerID" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dafb491becd249f55bef64d9cf5276d692dd75f7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977",
"triggerID" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"triggerType" : "PUSH"
}, {
"hash" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021",
"triggerID" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"triggerType" : "PUSH"
}, {
"hash" : "2e2b7be4e3ede352958733f19d58d39636627fa3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e2b7be4e3ede352958733f19d58d39636627fa3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dafb491becd249f55bef64d9cf5276d692dd75f7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021)
* 2e2b7be4e3ede352958733f19d58d39636627fa3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977",
"triggerID" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"triggerType" : "PUSH"
}, {
"hash" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021",
"triggerID" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"triggerType" : "PUSH"
}, {
"hash" : "2e2b7be4e3ede352958733f19d58d39636627fa3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30099",
"triggerID" : "2e2b7be4e3ede352958733f19d58d39636627fa3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e2b7be4e3ede352958733f19d58d39636627fa3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977",
"triggerID" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"triggerType" : "PUSH"
}, {
"hash" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021",
"triggerID" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd74a88227edf6a00098a9d651634e009ac3fe9f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977)
* dafb491becd249f55bef64d9cf5276d692dd75f7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977",
"triggerID" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd74a88227edf6a00098a9d651634e009ac3fe9f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18456: [FLINK-21790][network] Shuffle data directories to make directory selection of different TaskManagers fairer
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18456:
URL: https://github.com/apache/flink/pull/18456#issuecomment-1019691654
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977",
"triggerID" : "cd74a88227edf6a00098a9d651634e009ac3fe9f",
"triggerType" : "PUSH"
}, {
"hash" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dafb491becd249f55bef64d9cf5276d692dd75f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd74a88227edf6a00098a9d651634e009ac3fe9f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29977)
* dafb491becd249f55bef64d9cf5276d692dd75f7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org