You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/08 18:42:50 UTC

[GitHub] [spark] vanzin commented on a change in pull request #23980: [SPARK-27063][K8S] Up timeouts for slower clusters

vanzin commented on a change in pull request #23980: [SPARK-27063][K8S] Up timeouts for slower clusters
URL: https://github.com/apache/spark/pull/23980#discussion_r263885479
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
 ##########
 @@ -105,7 +105,7 @@ private[spark] trait SecretsTestsSuite { k8sSuite: KubernetesSuite =>
       .withTTY()
       .exec(cmd.toArray: _*)
     // wait to get some result back
-    Thread.sleep(1000)
+    Thread.sleep(5000)
 
 Review comment:
   Is there a better way to check for completion other than sleeping for some arbitrary period?
   
   Because if there is you could use `eventually`, for example, and use an even longer timeout without penalizing cases where the command executes quickly.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org