You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2023/01/19 08:12:09 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #504: Cleanup UnitConverter and improve UnitConverterTest
kaijchen opened a new pull request, #504:
URL: https://github.com/apache/incubator-uniffle/pull/504
### What changes were proposed in this pull request?
1. Remove unused code in UnitConverter.
2. Make UnitConverter final, and constructor private.
3. Improve coverage in UnitConverterTest.
### Why are the changes needed?
Code quality and test coverage.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen merged pull request #504: Cleanup UnitConverter and improve UnitConverterTest
Posted by GitBox <gi...@apache.org>.
kaijchen merged PR #504:
URL: https://github.com/apache/incubator-uniffle/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #504: Cleanup UnitConverter and improve UnitConverterTest
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #504:
URL: https://github.com/apache/incubator-uniffle/pull/504#issuecomment-1397213275
Thanks @jerqi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org