[GitHub] [airflow] bhirsz commented on a diff in pull request #23848: The first system test for slack (implemented according to AIP-47)

[GitBox <gi...@apache.org>]

bhirsz commented on code in PR #23848:
URL: https://github.com/apache/airflow/pull/23848#discussion_r887582041


##########
docs/exts/docs_build/lint_checks.py:
##########
@@ -268,7 +268,7 @@ def check_enforce_code_block() -> List[DocBuildError]:
 def find_example_dags(provider_dir):
     system_tests_dir = provider_dir.replace(f"{ROOT_PACKAGE_DIR}/", "")
     yield from glob(f"{provider_dir}/**/*example_dags", recursive=True)
-    yield from glob(f"{ROOT_PROJECT_DIR}/tests/system/{system_tests_dir}/*/", recursive=True)
+    yield from glob(f"{ROOT_PROJECT_DIR}/tests/system/{system_tests_dir}/**/example_dags", recursive=True)

Review Comment:
   Why the change? The ``find_example_dags`` should yield paths from two possible locations of the example dags - the one in the old and one in the new design of the system tests. So the second path shouldn't contain "example_dags" since it's pointing to the tests/system new directory. 
   
   If the docs tests cannot find your example dag due to invalid path - I can take a look to see what's the problem (most likely system_tests_dir is not something we expect). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org