[GitHub] SongYadong commented on a change in pull request #23902: SPARK-26999: Fix SparkSQL CLIDriver process line incorrectly

[GitBox <gi...@apache.org>]

SongYadong commented on a change in pull request #23902: SPARK-26999: Fix SparkSQL CLIDriver process line incorrectly
URL: https://github.com/apache/spark/pull/23902#discussion_r260616817
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
 ##########
 @@ -435,5 +489,68 @@ private[hive] class SparkSQLCLIDriver extends CliDriver with Logging {
       ret
     }
   }
+
+  override def processLine(line: String, allowInterrupting: Boolean): Int = {
+    var oldSignal: SignalHandler = null
+    var interruptSignal: Signal = null
+    if (allowInterrupting) { // Remember all threads that were running at the time we started line processing.
 
 Review comment:
   line is longer than 100 chars, may fails scalastyle check when building.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org