[GitHub] zheng-da commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.

[GitBox <gi...@apache.org>]

zheng-da commented on a change in pull request #12530: Implement mkldnn convolution fusion and quantization.
URL: https://github.com/apache/incubator-mxnet/pull/12530#discussion_r222543802
 
 

 ##########
 File path: src/operator/subgraph/subgraph_property.h
 ##########
 @@ -92,6 +92,22 @@ class SubgraphProperty {
   // execute the operators in the subgraph.
   virtual nnvm::NodePtr CreateSubgraphNode(const nnvm::Symbol &s,
                                            const int subgraph_id = 0) const = 0;
+  // Connect subgraph internal output with external output entries. By default,
+  // each output entry will connect to an unique internal output.
+  virtual void ConnectSubgraphOutputs(
+      const nnvm::NodePtr n,
+      std::vector<nnvm::NodeEntry *> *output_entries) const {
 
 Review comment:
   i think it's better check if `n` has the same number of outputs as `output_entries`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services