You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2008/02/16 18:56:29 UTC
[jira] Created: (MCHECKSTYLE-86) Lock down encoding used to read
source files
Lock down encoding used to read source files
--------------------------------------------
Key: MCHECKSTYLE-86
URL: http://jira.codehaus.org/browse/MCHECKSTYLE-86
Project: Maven 2.x Checkstyle Plugin
Issue Type: Improvement
Affects Versions: 2.1
Reporter: Benjamin Bentmann
Priority: Minor
Attachments: fixed-charset.patch
Since [version 3.5|http://checkstyle.sourceforge.net/releasenotes.html#Release%203.5], Checkstyle allows to configure the encoding used to read source files (somehow weird, they included this setting in the XML config which limits reusability among unrelated projects). Unless this is specified by the user via the [charset property|http://checkstyle.sourceforge.net/config.html#TreeWalker], it defaults to the system property "file.encoding". This makes the checks platform-dependent and possibly fail. For reproducible builds, the encoding should be locked down.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHECKSTYLE-86) Lock down encoding used to read
source files
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MCHECKSTYLE-86.
--------------------------------------
Resolution: Won't Fix
Fix Version/s: (was: 2.2)
> Lock down encoding used to read source files
> --------------------------------------------
>
> Key: MCHECKSTYLE-86
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-86
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Benjamin Bentmann
> Assignee: Dennis Lundberg
> Priority: Minor
> Attachments: fixed-charset.patch
>
>
> Since [version 3.5|http://checkstyle.sourceforge.net/releasenotes.html#Release%203.5], Checkstyle allows to configure the encoding used to read source files (somehow weird, they included this setting in the XML config which limits reusability among unrelated projects). Unless this is specified by the user via the [charset property|http://checkstyle.sourceforge.net/config.html#TreeWalker], it defaults to the system property "file.encoding". This makes the checks platform-dependent and possibly fail. For reproducible builds, the encoding should be locked down.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHECKSTYLE-86) Lock down encoding used to read
source files
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MCHECKSTYLE-86.
--------------------------------------
Assignee: Dennis Lundberg
Resolution: Fixed
Fix Version/s: 2.2
Patch applied in r628373. Thanks!
> Lock down encoding used to read source files
> --------------------------------------------
>
> Key: MCHECKSTYLE-86
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-86
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Benjamin Bentmann
> Assignee: Dennis Lundberg
> Priority: Minor
> Fix For: 2.2
>
> Attachments: fixed-charset.patch
>
>
> Since [version 3.5|http://checkstyle.sourceforge.net/releasenotes.html#Release%203.5], Checkstyle allows to configure the encoding used to read source files (somehow weird, they included this setting in the XML config which limits reusability among unrelated projects). Unless this is specified by the user via the [charset property|http://checkstyle.sourceforge.net/config.html#TreeWalker], it defaults to the system property "file.encoding". This makes the checks platform-dependent and possibly fail. For reproducible builds, the encoding should be locked down.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MCHECKSTYLE-86) Lock down encoding used to read
source files
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann reopened MCHECKSTYLE-86:
------------------------------------------
Needs to be reverted according to [user poll|http://www.nabble.com/-POLL--Default-Value-for-File-Encoding-to16958386.html#a16958386].
> Lock down encoding used to read source files
> --------------------------------------------
>
> Key: MCHECKSTYLE-86
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-86
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Benjamin Bentmann
> Assignee: Dennis Lundberg
> Priority: Minor
> Fix For: 2.2
>
> Attachments: fixed-charset.patch
>
>
> Since [version 3.5|http://checkstyle.sourceforge.net/releasenotes.html#Release%203.5], Checkstyle allows to configure the encoding used to read source files (somehow weird, they included this setting in the XML config which limits reusability among unrelated projects). Unless this is specified by the user via the [charset property|http://checkstyle.sourceforge.net/config.html#TreeWalker], it defaults to the system property "file.encoding". This makes the checks platform-dependent and possibly fail. For reproducible builds, the encoding should be locked down.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira