You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/09/08 00:45:39 UTC

[GitHub] [gobblin] aplex commented on a change in pull request #3387: [GOBBLIN-1537] use DestinationDatasetHandlerService while creating trash location

aplex commented on a change in pull request #3387:
URL: https://github.com/apache/gobblin/pull/3387#discussion_r703942804



##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/trash/Trash.java
##########
@@ -94,6 +97,8 @@ public Path getTrashLocation() throws IOException {
    */
   protected Path createTrashLocation(FileSystem fs, Properties props, String user) throws IOException {
     Path trashLocation;
+    new DestinationDatasetHandlerService(new State(props), false, null)

Review comment:
       What will this do? Add something to props? Can we get the trash folder or dataset root folder directly, through the statically-typed APIs, instead of a global collection of props?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org