You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/02/08 23:40:24 UTC
[kudu-CR] TSTabletManager::DeleteTabletData() should log delete type on success
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9259
to review the following change.
Change subject: TSTabletManager::DeleteTabletData() should log delete_type on success
......................................................................
TSTabletManager::DeleteTabletData() should log delete_type on success
Change-Id: I5520334b86a540e6df64fa7036a7a83a7db473ac
---
M src/kudu/tserver/ts_tablet_manager.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/9259/1
--
To view, visit http://gerrit.cloudera.org:8080/9259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5520334b86a540e6df64fa7036a7a83a7db473ac
Gerrit-Change-Number: 9259
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] TSTabletManager::DeleteTabletData() should log delete type on success
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9259 )
Change subject: TSTabletManager::DeleteTabletData() should log delete_type on success
......................................................................
TSTabletManager::DeleteTabletData() should log delete_type on success
Change-Id: I5520334b86a540e6df64fa7036a7a83a7db473ac
Reviewed-on: http://gerrit.cloudera.org:8080/9259
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tserver/ts_tablet_manager.cc
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5520334b86a540e6df64fa7036a7a83a7db473ac
Gerrit-Change-Number: 9259
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] TSTabletManager::DeleteTabletData() should log delete type on success
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9259 )
Change subject: TSTabletManager::DeleteTabletData() should log delete_type on success
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5520334b86a540e6df64fa7036a7a83a7db473ac
Gerrit-Change-Number: 9259
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 09 Feb 2018 01:04:46 +0000
Gerrit-HasComments: No