You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by DivineEnder <gi...@git.apache.org> on 2017/05/24 23:26:52 UTC

[GitHub] geode pull request #532: GEODE-2950: Adding validation checks on create Luce...

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/532

    GEODE-2950: Adding validation checks on create Lucene index parameter…

    … names
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-2950

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/532.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #532
    
----
commit db35110899adad1372f1f832344608dcf457a639
Author: David Anuta <da...@gmail.com>
Date:   2017-05-24T23:21:33Z

    GEODE-2950: Adding validation checks on create lucene index parameter names

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #532: GEODE-2950: Adding validation checks on create Lucene inde...

Posted by DivineEnder <gi...@git.apache.org>.
Github user DivineEnder commented on the issue:

    https://github.com/apache/geode/pull/532
  
    @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #532: GEODE-2950: Adding validation checks on create Luce...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/532


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---