general/4807

[Dirk <di...@teleport.com>]

The following reply was made to PR general/4807; it has been noted by GNATS.

From: Dirk <di...@teleport.com>
To: apbugs@apache.org
Cc: pete-apache@kazmier.com, demyers@pscnet.com, asmorris@pscnet.com
Subject: general/4807
Date: Mon, 9 Aug 1999 21:18:52 -0700 (PDT)

 Hi, I also ran into this bug today.  It looks like what's happening is
 that the warning falls between pass one and pass two in the
 handler-matching section of http_config.c
 
 Moving the warning until after the second pass suppresses the
 error unless the second pass also fails to match; I'm not sure that it's
 the right fix, though, as at this point the program returns a server
 error rather than just raising a warning.  Anyway, I'm using this locally
 to quiet apache down as matching on the second pass doesn't seem to cause
 any problems.   I figured I might as well submit the patch:
 
 Dirk
 dirkm@teleport.com
 
 -----snip here-----
 
 
 --- http_config_orig.c	Mon Aug  9 21:07:20 1999
 +++ http_config.c	Mon Aug  9 21:08:01 1999
 @@ -512,10 +512,7 @@
          }
      }
  
 -    if (result == HTTP_INTERNAL_SERVER_ERROR && r->handler) {
 -        ap_log_rerror(APLOG_MARK, APLOG_NOERRNO|APLOG_WARNING, r,
 -            "handler \"%s\" not found for: %s", r->handler, r->filename);
 -    }
 +  
  
      /* Pass two --- wildcard matches */
  
 @@ -527,6 +524,13 @@
               if (result != DECLINED)
                   return result;
           }
 +    }
 +
 +	/* if this is before pass two, we get spurious warnings */
 +	
 +  if (result == HTTP_INTERNAL_SERVER_ERROR && r->handler) {
 +        ap_log_rerror(APLOG_MARK, APLOG_NOERRNO|APLOG_WARNING, r,
 +            "handler \"%s\" not found for: %s", r->handler, r->filename);
      }
  
      return HTTP_INTERNAL_SERVER_ERROR;