You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/08/05 14:44:43 UTC

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #27883: PostgreSQL Support Rename Column

strongduanmu commented on code in PR #27883:
URL: https://github.com/apache/shardingsphere/pull/27883#discussion_r1285069059


##########
parser/sql/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java:
##########
@@ -419,6 +419,9 @@ public ASTNode visitAlterDefinitionClause(final AlterDefinitionClauseContext ctx
         if (null != ctx.alterTableActions()) {
             result.getValue().addAll(ctx.alterTableActions().alterTableAction().stream().flatMap(each -> getAlterDefinitionSegments(each).stream()).collect(Collectors.toList()));
         }
+        if (null != ctx.renameColumnSpecification()) {

Review Comment:
   Can you add sql parser test for this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org