You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "llowinge (via GitHub)" <gi...@apache.org> on 2023/08/10 17:59:42 UTC
[GitHub] [camel-quarkus] llowinge commented on a diff in pull request #5170: [5162] Add elasticsearch tests
llowinge commented on code in PR #5170:
URL: https://github.com/apache/camel-quarkus/pull/5170#discussion_r1290493776
##########
integration-tests-jvm/elasticsearch/src/test/java/org/apache/camel/quarkus/component/elasticsearch/it/ElasticsearchTest.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.elasticsearch.it;
+
+import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+
+import io.quarkus.test.common.QuarkusTestResource;
+import io.quarkus.test.junit.QuarkusTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+import org.awaitility.Awaitility;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import static org.hamcrest.Matchers.is;
+
+@QuarkusTest
+@QuarkusTestResource(ElasticsearchTestResource.class)
+class ElasticsearchTest {
+
+ @AfterEach
+ public void afterEach() {
+ // Clean up all indexed data
+ RestAssured.given()
+ .queryParam("component", "elasticsearch")
+ .queryParam("indexName", "_all")
+ .delete("/elasticsearch/delete/index")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+ }
+
+ @ParameterizedTest
+ @MethodSource("componentNames")
+ public void testElasticsearchBasicOperations(String component) {
+ String indexName = UUID.randomUUID().toString();
+ String indexKey = "test-key";
+ String indexValue = "Hello Camel Quarkus ElasticSearch";
+
+ // Verify the ElasticSearch server is available
+ RestAssured.given()
+ .queryParam("component", component)
+ .get("/elasticsearch/ping")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+
+ // Index data
+ String indexId = RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexKey", indexKey)
+ .contentType(ContentType.TEXT)
+ .body(indexValue)
+ .post("/elasticsearch/index")
+ .then()
+ .statusCode(201)
+ .extract()
+ .body()
+ .asString();
+
+ // Verify index exists
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .get("/elasticsearch/exists")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+
+ // Retrieve indexed data
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexId", indexId)
+ .queryParam("indexKey", indexKey)
+ .get("/elasticsearch/get")
+ .then()
+ .statusCode(200)
+ .body(is(indexValue));
+
+ // Update indexed data
+ String updatedIndexValue = indexValue + " Updated";
+ RestAssured.given()
+ .contentType(ContentType.TEXT)
+ .queryParam("component", component)
+ .queryParam("indexId", indexId)
+ .queryParam("indexName", indexName)
+ .queryParam("indexKey", indexKey)
+ .body(updatedIndexValue)
+ .patch("/elasticsearch/update")
+ .then()
+ .statusCode(200);
+
+ // Verify updated data
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexId", indexId)
+ .queryParam("indexKey", indexKey)
+ .get("/elasticsearch/get")
+ .then()
+ .statusCode(200)
+ .body(is(updatedIndexValue));
+
+ // Delete indexed data
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexId", indexId)
+ .delete("/elasticsearch/delete")
+ .then()
+ .statusCode(204);
+
+ // Verify data deleted
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexId", indexId)
+ .queryParam("indexKey", indexKey)
+ .get("/elasticsearch/get")
+ .then()
+ .statusCode(404);
+ }
+
+ @ParameterizedTest
+ @MethodSource("componentNames")
+ public void testElasticsearchBulk(String component) {
+ String indexName = UUID.randomUUID().toString();
+
+ String indexId = RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .post("/elasticsearch/bulk")
+ .then()
+ .statusCode(200)
+ .extract()
+ .body()
+ .asString();
+
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .get("/elasticsearch/exists")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexId", indexId)
+ .queryParam("indexKey", "camel")
+ .get("/elasticsearch/get")
+ .then()
+ .statusCode(200)
+ .body(is("quarkus"));
+ }
+
+ @ParameterizedTest
+ @MethodSource("componentNames")
+ public void testElasticsearchDeleteIndex(String component) {
+ String indexName = UUID.randomUUID().toString();
+ String indexKey = "test-key";
+ String indexValue = "Hello Camel Quarkus ElasticSearch";
+
+ // Index data
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexKey", indexKey)
+ .contentType(ContentType.TEXT)
+ .body(indexValue)
+ .post("/elasticsearch/index")
+ .then()
+ .statusCode(201)
+ .extract()
+ .body()
+ .asString();
+
+ // Verify index exists
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .get("/elasticsearch/exists")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+
+ // Delete indexed data
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .delete("/elasticsearch/delete/index")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+ }
+
+ @ParameterizedTest
+ @MethodSource("componentNames")
+ public void testElasticsearchSearch(String component) {
+ String indexName = UUID.randomUUID().toString();
+ String indexKey = "camel-quarkus";
+ String indexValue = "Sub Atomic, Super Fast Camel Quarkus";
+
+ // Index data
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexKey", indexKey)
+ .contentType(ContentType.TEXT)
+ .body(indexValue)
+ .post("/elasticsearch/index")
+ .then()
+ .statusCode(201)
+ .extract()
+ .body()
+ .asString();
+
+ // Verify index exists
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .get("/elasticsearch/exists")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+
+ // Search data
+ Awaitility.await().pollInterval(50, TimeUnit.MILLISECONDS).atMost(10, TimeUnit.SECONDS).until(() -> {
+ String searchResult = RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexKey", indexKey)
+ .body("Super Fast")
+ .get("/elasticsearch/search")
+ .then()
+ .statusCode(200)
+ .extract()
+ .body()
+ .asString();
+ return searchResult.equals(indexValue);
+ });
+ }
+
+ @ParameterizedTest
+ @MethodSource("componentNames")
+ public void testElasticsearchSearchJSON(String component) {
+ String indexName = UUID.randomUUID().toString();
+ String indexKey = "camel-quarkus";
+ String indexValue = "Sub Atomic, Super Fast Camel Quarkus";
+
+ // Index data
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexKey", indexKey)
+ .contentType(ContentType.TEXT)
+ .body(indexValue)
+ .post("/elasticsearch/index")
+ .then()
+ .statusCode(201)
+ .extract()
+ .body()
+ .asString();
+
+ // Verify index exists
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .get("/elasticsearch/exists")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+
+ // Search data
+ Awaitility.await().pollInterval(50, TimeUnit.MILLISECONDS).atMost(10, TimeUnit.SECONDS).until(() -> {
+ String searchResult = RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexKey", indexKey)
+ .body("Super Fast")
+ .get("/elasticsearch/search/json")
+ .then()
+ .statusCode(200)
+ .extract()
+ .body()
+ .asString();
+ return searchResult.equals(indexValue);
+ });
+ }
+
+ @ParameterizedTest
+ @MethodSource("componentNames")
+ public void testElasticsearchMultiSearch(String component) {
+ String indexName = UUID.randomUUID().toString();
+ String indexKey = "camel-quarkus";
+ String indexValue = "Sub Atomic, Super Fast Camel Quarkus";
+
+ // Index data
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexKey", indexKey)
+ .contentType(ContentType.TEXT)
+ .body(indexValue)
+ .post("/elasticsearch/index")
+ .then()
+ .statusCode(201)
+ .extract()
+ .body()
+ .asString();
+
+ // Verify index exists
+ RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .get("/elasticsearch/exists")
+ .then()
+ .statusCode(200)
+ .body(is("true"));
+
+ // Search data
+ Awaitility.await().pollInterval(50, TimeUnit.MILLISECONDS).atMost(100, TimeUnit.SECONDS).until(() -> {
+ String hits = RestAssured.given()
+ .queryParam("component", component)
+ .queryParam("indexName", indexName)
+ .queryParam("indexKey", indexKey)
+ .body("Sub Atomic,Super Fast,Nonsense")
+ .get("/elasticsearch/search/multi")
+ .then()
+ .statusCode(200)
+ .extract()
+ .body()
+ .asString();
+ return hits.equals("2");
+ });
+ }
+
+ @SuppressWarnings("unused")
+ private static String[] componentNames() {
+ return new String[] { "elasticsearch" };
Review Comment:
I left it there for the Quarkus managed ES client. But i agree it is not useful now at all. Maybe i should add comment there why it is done like that to that method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org