You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/13 02:40:33 UTC

[GitHub] [trafficserver] masaori335 commented on a change in pull request #6997: Cleanup: Write error on diags output instead of stderr

masaori335 commented on a change in pull request #6997:
URL: https://github.com/apache/trafficserver/pull/6997#discussion_r453405976



##########
File path: proxy/http/HttpTunnel.cc
##########
@@ -1499,9 +1499,7 @@ HttpTunnel::finish_all_internal(HttpTunnelProducer *p, bool chain)
         ink_assert(c->write_vio->nbytes >= 0);
 
         if (c->write_vio->nbytes < 0) {
-          // TODO: Wtf, printf?
-          fprintf(stderr, "[HttpTunnel::finish_all_internal] ERROR: Incorrect total_bytes - c->skip_bytes = %" PRId64 "\n",
-                  static_cast<int64_t>(total_bytes - c->skip_bytes));

Review comment:
       Both of `total_bytes` & `c->skip_bytes` are `int64_t`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org