You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/17 14:01:47 UTC

[GitHub] [flink] snuyanzin opened a new pull request, #19750: [FLINK-27669][tests] Migrate flink-file-sink-common to JUnit5

snuyanzin opened a new pull request, #19750:
URL: https://github.com/apache/flink/pull/19750

   ## What is the purpose of the change
   
   Update the flink-file-sink-common module to AssertJ and JUnit 5 following the [JUnit 5 Migration Guide](https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit)
   
   
   ## Brief change log
   
   Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest
   
   
   ## Verifying this change
   
   This change is a code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
     - The S3 file system connector: (no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no )
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin commented on pull request #19750: [FLINK-27669][tests] Migrate flink-file-sink-common to JUnit5

Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #19750:
URL: https://github.com/apache/flink/pull/19750#issuecomment-1129088650

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19750: [FLINK-27669][tests] Migrate flink-file-sink-common to JUnit5

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19750:
URL: https://github.com/apache/flink/pull/19750#issuecomment-1128913895

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7058b2e6988e5a523725bce905f66c8a89b94371",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7058b2e6988e5a523725bce905f66c8a89b94371",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7058b2e6988e5a523725bce905f66c8a89b94371 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #19750: [FLINK-27669][tests] Migrate flink-file-sink-common to JUnit5

Posted by GitBox <gi...@apache.org>.
zentol merged PR #19750:
URL: https://github.com/apache/flink/pull/19750


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org