You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Prashant Satam <pr...@gmail.com> on 2023/08/10 05:03:23 UTC

Review Request 74542: RANGER-4346: Need to Change type of column resource_signature in table x_gds_shared_resource to TEXT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74542/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.


Bugs: RANGER-4346
    https://issues.apache.org/jira/browse/RANGER-4346


Repository: ranger


Description
-------

Need to change the type of column resource_signature in table x_gds_shared_resource to text from present varchar(128) ,As customers will have large data so existing size will not be enough


Diffs
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql b4e3f57b8 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 6b82aead4 


Diff: https://reviews.apache.org/r/74542/diff/1/


Testing
-------

When we create tables by schema we can see the TYPE for column resource_signature as TEXT which was previously varchar(128)


Thanks,

Prashant Satam


Re: Review Request 74542: RANGER-4346: Need to Change type of column resource_signature in table x_gds_shared_resource to TEXT

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74542/#review225652
-----------------------------------------------------------




security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql
Line 1792 (original), 1792 (patched)
<https://reviews.apache.org/r/74542/#comment314118>

    Length of resource signature should remain the same irrespective of the length of resource values. I see that the signature computation in RangerGdsSharedResourceService is incorrect.
    
    This line should be changed, from:
     xObj.setResourceSignature(RangerPolicyResourceSignature.toSignatureString(vObj.getResource()));
    
    to:
     xObj.setResourceSignature(new RangerPolicyResourceSignature(vObj.getResource()).getSignature());


- Madhan Neethiraj


On Aug. 10, 2023, 5:03 a.m., Prashant Satam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74542/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2023, 5:03 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4346
>     https://issues.apache.org/jira/browse/RANGER-4346
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Need to change the type of column resource_signature in table x_gds_shared_resource to text from present varchar(128) ,As customers will have large data so existing size will not be enough
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql b4e3f57b8 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 6b82aead4 
> 
> 
> Diff: https://reviews.apache.org/r/74542/diff/1/
> 
> 
> Testing
> -------
> 
> When we create tables by schema we can see the TYPE for column resource_signature as TEXT which was previously varchar(128)
> 
> 
> Thanks,
> 
> Prashant Satam
> 
>


Re: Review Request 74542: RANGER-4346: Need to Change type of column resource_signature in table x_gds_shared_resource to TEXT

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74542/#review225655
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 16, 2023, 10:44 a.m., Prashant Satam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74542/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2023, 10:44 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4346
>     https://issues.apache.org/jira/browse/RANGER-4346
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Need to change the type of column resource_signature in table x_gds_shared_resource to text from present varchar(128) ,As customers will have large data so existing size will not be enough
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java c14811867 
>   security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java 33fbd3ce4 
> 
> 
> Diff: https://reviews.apache.org/r/74542/diff/2/
> 
> 
> Testing
> -------
> 
> When we create tables by schema we can see the TYPE for column resource_signature as TEXT which was previously varchar(128)
> 
> 
> Thanks,
> 
> Prashant Satam
> 
>


Re: Review Request 74542: RANGER-4346: Need to Change type of column resource_signature in table x_gds_shared_resource to TEXT

Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74542/
-----------------------------------------------------------

(Updated Aug. 16, 2023, 10:44 a.m.)


Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.


Bugs: RANGER-4346
    https://issues.apache.org/jira/browse/RANGER-4346


Repository: ranger


Description
-------

Need to change the type of column resource_signature in table x_gds_shared_resource to text from present varchar(128) ,As customers will have large data so existing size will not be enough


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java c14811867 
  security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java 33fbd3ce4 


Diff: https://reviews.apache.org/r/74542/diff/2/

Changes: https://reviews.apache.org/r/74542/diff/1-2/


Testing
-------

When we create tables by schema we can see the TYPE for column resource_signature as TEXT which was previously varchar(128)


Thanks,

Prashant Satam