You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:19:57 UTC
[GitHub] [sling-org-apache-sling-auth-core] enapps-enorman opened a new pull request #11: SLING-10166 Fix issues reported by sonar
enapps-enorman opened a new pull request #11:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/11
Current sonar status shows:
92 Issues
3 Bugs
7 Vulnerabilities
0 Security Hotspots
82 Code Smells
Also update to parent 43 and ensure ReadOnlyAuthenticationInfo is fully immutable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #11: SLING-10166 Fix issues reported by sonar
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #11:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/11#issuecomment-863445303
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='35.6%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&metric=new_coverage&view=list) [35.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=11&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] enapps-enorman commented on pull request #11: SLING-10166 Fix issues reported by sonar
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on pull request #11:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/11#issuecomment-863449498
I believe the remaining sonar issues are all:
1. warnings about removing deprecated code at some point
2. warnings about reducing cognitive complexity which can maybe be considered later
If there are no objections in a few days I'll merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] enapps-enorman merged pull request #11: SLING-10166 Fix issues reported by sonar
Posted by GitBox <gi...@apache.org>.
enapps-enorman merged pull request #11:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] enapps-enorman merged pull request #11: SLING-10166 Fix issues reported by sonar
Posted by GitBox <gi...@apache.org>.
enapps-enorman merged pull request #11:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org