[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35422: [SPARK-36061][K8S] Add Volcano feature step and enable user specified minimum resources

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35422:
URL: https://github.com/apache/spark/pull/35422#discussion_r800986656



##########
File path: resource-managers/kubernetes/core/pom.xml
##########
@@ -52,6 +52,12 @@
       <type>test-jar</type>
     </dependency>
 
+    <dependency>
+      <groupId>io.fabric8</groupId>
+      <artifactId>volcano-model-v1beta1</artifactId>
+      <version>${kubernetes-client.version}</version>
+    </dependency>

Review comment:
       Technically, Apache Spark uses three options when it embraces new features. I'd prefer (2). Shall we put this under `-Pvolcano` profile please?
   1. `External module` like `Kafka Streaming`
   2. `Profile` like `HiveThriftServer` or `SparkR`
   3. Built-in module.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org