You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/12 09:57:58 UTC
[GitHub] [camel-website] AghaSaad04 opened a new pull request #199: Removed
unused html from header
AghaSaad04 opened a new pull request #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199
Signed-off-by: Agha Saad Fraz <ag...@gmail.com>
I have removed the unused HTML from the header. It was not visible to users because of the styling and was of no use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-599241775
@AghaSaad04 when we change the templates in Hugo layout we also need to make the corresponding change to the Antora UI. See a58201e.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 commented on issue #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
AghaSaad04 commented on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-598664837
@zregvart I looked more into this and to my best knowledge we may have to remove the CSS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 commented on issue #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
AghaSaad04 commented on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-599040074
@zregvart This is what I have got after researching about the title attribute:
> Values of the title attribute may be rendered by user agents in a variety of ways. For instance, visual browsers frequently display the title as a "tool tip" (a short message that appears when the pointing device pauses over an object). **Audio user agents** may speak the title information in a similar context. For example, setting the attribute on a link allows user agents (visual and non-visual) to tell users about the nature of the linked resource
Anyone interested can visit [this](https://stackoverflow.com/questions/4216035/css-background-image-alt-attribute)
So I think we are helping the screen readers and all those dont load images.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 commented on issue #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
AghaSaad04 commented on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-598138650
Sure @zregvart. I will look more into this and will update the PR if required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 commented on issue #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
AghaSaad04 commented on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-599245143
@zregvart thanks for the info. I will update both from now on if I make any change :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-598134058
I think the idea of that non visible <span> is to help folk that don't load images or use a screen reader to have the text "Apache Camel" there for them.
We do have a `title` attribute on the logo, so that might help. Would appreciate some research on this.
If we merge this and remove the span this section of the CSS also needs to be removed:
https://github.com/apache/camel-website/blob/9c2ddbe4130d230f6466c88ff1d5276f952c1d42/antora-ui-camel/src/css/nav.css#L298-L307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 commented on issue #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
AghaSaad04 commented on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-599222861
Thanks, @zregvart for the article you mentioned, I will read that now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #199: Removed unused
html from header
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-598694631
> @zregvart I looked more into this and to my best knowledge we may have to remove the CSS.
What about screen readers and folk that don't load images, can we help them also?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AghaSaad04 edited a comment on issue #199: Removed
unused html from header
Posted by GitBox <gi...@apache.org>.
AghaSaad04 edited a comment on issue #199: Removed unused html from header
URL: https://github.com/apache/camel-website/pull/199#issuecomment-599040074
@zregvart This is what I have got after researching about the title attribute:
> Values of the title attribute may be rendered by user agents in a variety of ways. For instance, visual browsers frequently display the title as a "tool tip" (a short message that appears when the pointing device pauses over an object). **Audio user agents** may speak the title information in a similar context. For example, setting the attribute on a link allows user agents (visual and non-visual) to tell users about the nature of the linked resource
Anyone interested can visit [this](https://stackoverflow.com/questions/4216035/css-background-image-alt-attribute)
So I think we are helping the screen readers and all those dont load images as we already have **title attribute** in our **anchor tag**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services