You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2005/02/03 07:45:12 UTC

[jira] Created: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-71

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-71
    Summary: Better support for multiproject with eclipse plugin
       Type: New Feature

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin

   Assignee: 
   Reporter: Yujin Kim

    Created: Thu, 3 Feb 2005 1:45 AM
    Updated: Thu, 3 Feb 2005 1:45 AM

Description:
Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.

for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :

src/java -> target/classes
src/test -> target/test-classes
B/src/java -> target/classes
B/src/test -> target/test-classes
C/src/java -> target/classes
C/src/test -> target/test-classes

If I get a chance, I'll post a patch.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by "Max Rudman (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-71?page=comments#action_52840 ] 

Max Rudman commented on MPECLIPSE-71:
-------------------------------------

I had the same need and created my own version. Submitted patch is actually more robust than what I did so I am not submitting mine. However, I have a couple of suggestions:

1) Generated sources dir for nested projects should be obtained with something like this:

<j:set var="nestedContext" value="${reactorProject.context}"/>
<j:invoke var="genSrc" on="${nestedContext}" method="getVariable">
    <j:arg value="maven.gen.src"/>
</j:invoke>

This way nested project's potentially different setting is respected. Same should be done for maven.build.dir

2) I put multiproject handling into a separate "multiclasspath.jelly" file and included it in the main classpath.jelly. I like smaller files as I feel they are easier to work with/find things in.

> Better support for multiproject with eclipse plugin
> ---------------------------------------------------
>
>          Key: MPECLIPSE-71
>          URL: http://jira.codehaus.org/browse/MPECLIPSE-71
>      Project: maven-eclipse-plugin
>         Type: New Feature
>     Reporter: Yujin Kim
>     Priority: Minor
>  Attachments: classpath.jelly.MPECLIPSE-71.zip, classpath.jelly.patch, maven-eclipse-plugin-test.zip
>
>
> Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.
> for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :
> src/java -> target/classes
> src/test -> target/test-classes
> B/src/java -> target/classes
> B/src/test -> target/test-classes
> C/src/java -> target/classes
> C/src/test -> target/test-classes
> If I get a chance, I'll post a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by "Yujin Kim (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPECLIPSE-71?page=comments#action_39459 ]
     
Yujin Kim commented on MPECLIPSE-71:
------------------------------------

use classpath.jelly.MPECLIPSE-71.zip for SVN.
also addd one propject properties but wasn't sure where it needs to be patched.
           
maven.multiproject.eclipse.includes:  if not set, falls back to maven.multproject.includes, or "*/project.xml" if it's not set either
maven.multiproject.eclipse.excludes: to exclude subprojcet from being included in the eclipse classpath. (such as sandbox projects).

One issue I know still exists is when you have multiproject stucture for webapps.  The way this is done, you can't have a subproject level dependency.  Because eclipse doesn't support multi-tier project, for eclipse project to be able to see the dependencies is to have the dependencies declared at the top level project.

> Better support for multiproject with eclipse plugin
> ---------------------------------------------------
>
>          Key: MPECLIPSE-71
>          URL: http://jira.codehaus.org/browse/MPECLIPSE-71
>      Project: maven-eclipse-plugin
>         Type: New Feature
>     Reporter: Yujin Kim
>     Priority: Minor
>  Attachments: classpath.jelly.MPECLIPSE-71.zip, classpath.jelly.patch, maven-eclipse-plugin-test.zip
>
>
> Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.
> for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :
> src/java -> target/classes
> src/test -> target/test-classes
> B/src/java -> target/classes
> B/src/test -> target/test-classes
> C/src/java -> target/classes
> C/src/test -> target/test-classes
> If I get a chance, I'll post a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by "Yujin Kim (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-71?page=comments#action_41462 ] 

Yujin Kim commented on MPECLIPSE-71:
------------------------------------

Since i uploaded the patch, I also added eclipse project depdency handling, so inside eclipse, i can let eclipse build multiple "eclipse" projects without having to rely on maven, while continuous build, etc can still use maven to build it.

i'll submit a patch if/when the above patch(or the one in agila) makes it to the main tree.

> Better support for multiproject with eclipse plugin
> ---------------------------------------------------
>
>          Key: MPECLIPSE-71
>          URL: http://jira.codehaus.org/browse/MPECLIPSE-71
>      Project: maven-eclipse-plugin
>         Type: New Feature
>     Reporter: Yujin Kim
>     Priority: Minor
>  Attachments: classpath.jelly.MPECLIPSE-71.zip, classpath.jelly.patch, maven-eclipse-plugin-test.zip
>
>
> Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.
> for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :
> src/java -> target/classes
> src/test -> target/test-classes
> B/src/java -> target/classes
> B/src/test -> target/test-classes
> C/src/java -> target/classes
> C/src/test -> target/test-classes
> If I get a chance, I'll post a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by ji...@codehaus.org.
The following comment has been added to this issue:

     Author: David Eric Pugh
    Created: Wed, 2 Mar 2005 1:01 PM
       Body:
For some reason, I don't think your patch was actually attached.  Can you try again?
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-71?page=comments#action_30419

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-71

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-71
    Summary: Better support for multiproject with eclipse plugin
       Type: New Feature

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin

   Assignee: 
   Reporter: Yujin Kim

    Created: Thu, 3 Feb 2005 1:45 AM
    Updated: Wed, 2 Mar 2005 1:01 PM

Description:
Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.

for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :

src/java -> target/classes
src/test -> target/test-classes
B/src/java -> target/classes
B/src/test -> target/test-classes
C/src/java -> target/classes
C/src/test -> target/test-classes

If I get a chance, I'll post a patch.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by "Yujin Kim (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPECLIPSE-71?page=all ]

Yujin Kim updated MPECLIPSE-71:
-------------------------------

    Attachment: classpath.jelly.MPECLIPSE-71.zip

uploading the patch for svn.  (previous patch was based on cvs)

> Better support for multiproject with eclipse plugin
> ---------------------------------------------------
>
>          Key: MPECLIPSE-71
>          URL: http://jira.codehaus.org/browse/MPECLIPSE-71
>      Project: maven-eclipse-plugin
>         Type: New Feature
>     Reporter: Yujin Kim
>     Priority: Minor
>  Attachments: classpath.jelly.MPECLIPSE-71.zip, classpath.jelly.patch, maven-eclipse-plugin-test.zip
>
>
> Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.
> for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :
> src/java -> target/classes
> src/test -> target/test-classes
> B/src/java -> target/classes
> B/src/test -> target/test-classes
> C/src/java -> target/classes
> C/src/test -> target/test-classes
> If I get a chance, I'll post a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by ji...@codehaus.org.
The following comment has been added to this issue:

     Author: Yujin Kim
    Created: Thu, 3 Feb 2005 2:55 PM
       Body:
Actually I take back what I said.  Currently maven-eclipse plugin doesn't support multiproject period.  I forgot I had to write my own jelly tag to make it work in our multiproject environment.

I think I do have a solution for this and will post a patch (will need to modify classpath.jelly) for this whenever I can.

- yujin
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-71?page=comments#action_29543

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-71

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-71
    Summary: Better support for multiproject with eclipse plugin
       Type: New Feature

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin

   Assignee: 
   Reporter: Yujin Kim

    Created: Thu, 3 Feb 2005 1:45 AM
    Updated: Thu, 3 Feb 2005 2:55 PM

Description:
Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.

for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :

src/java -> target/classes
src/test -> target/test-classes
B/src/java -> target/classes
B/src/test -> target/test-classes
C/src/java -> target/classes
C/src/test -> target/test-classes

If I get a chance, I'll post a patch.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: Yujin Kim (mailto:yujin@iname.com)
       Date: Sat, 5 Feb 2005 1:19 PM
    Comment:
adding a test project i used to test the plugin patch.
    Changes:
             Attachment changed to maven-eclipse-plugin-test.zip
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPECLIPSE-71?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-71

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-71
    Summary: Better support for multiproject with eclipse plugin
       Type: New Feature

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin

   Assignee: 
   Reporter: Yujin Kim

    Created: Thu, 3 Feb 2005 1:45 AM
    Updated: Sat, 5 Feb 2005 1:19 PM

Description:
Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.

for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :

src/java -> target/classes
src/test -> target/test-classes
B/src/java -> target/classes
B/src/test -> target/test-classes
C/src/java -> target/classes
C/src/test -> target/test-classes

If I get a chance, I'll post a patch.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: Yujin Kim (mailto:yujin@iname.com)
       Date: Sat, 5 Feb 2005 1:18 PM
    Comment:
patch for allowing multiproject .classpath generation.
i tried avoid making risks and pretty much copied the code that handles the single project classpath and put that into a loop using reactor.  

limitation: if the sub project is not under the current root, this probably won't work, ie if root project A and child project B are at the same level, instead of B residing under A, this will most likely fail.

also i didn't put too much effort into parsing the exclude filter for reactor.  just checking if it's empty then add the root project.  I think eventually the part that handles the single project and the code i added can be merged.
    Changes:
             Attachment changed to classpath.jelly.patch
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPECLIPSE-71?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-71

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-71
    Summary: Better support for multiproject with eclipse plugin
       Type: New Feature

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-eclipse-plugin

   Assignee: 
   Reporter: Yujin Kim

    Created: Thu, 3 Feb 2005 1:45 AM
    Updated: Sat, 5 Feb 2005 1:18 PM

Description:
Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.

for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :

src/java -> target/classes
src/test -> target/test-classes
B/src/java -> target/classes
B/src/test -> target/test-classes
C/src/java -> target/classes
C/src/test -> target/test-classes

If I get a chance, I'll post a patch.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPECLIPSE-71) Better support for multiproject with eclipse plugin

Posted by "Scott Lamb (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-71?page=comments#action_41457 ] 

Scott Lamb commented on MPECLIPSE-71:
-------------------------------------

There's another patch at http://issues.apache.org/jira/browse/AGILA-13 which I had some success with.

> Better support for multiproject with eclipse plugin
> ---------------------------------------------------
>
>          Key: MPECLIPSE-71
>          URL: http://jira.codehaus.org/browse/MPECLIPSE-71
>      Project: maven-eclipse-plugin
>         Type: New Feature
>     Reporter: Yujin Kim
>     Priority: Minor
>  Attachments: classpath.jelly.MPECLIPSE-71.zip, classpath.jelly.patch, maven-eclipse-plugin-test.zip
>
>
> Currently when eclipse generates .classpath file, the subprojects' target paths default to the parent project's target path.
> for example if you have a POM A which is a parent project, and POM B and C that are subprojects of A, generated classpath will have :
> src/java -> target/classes
> src/test -> target/test-classes
> B/src/java -> target/classes
> B/src/test -> target/test-classes
> C/src/java -> target/classes
> C/src/test -> target/test-classes
> If I get a chance, I'll post a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org