[jira] [Commented] (CAMEL-20634) Create a centralized variable for the header name CamelLangChain4jEmbeddingsVector

["Zineb Bendhiba (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-20634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862482#comment-17862482 ] 

Zineb Bendhiba commented on CAMEL-20634:
----------------------------------------

Yes, it is.

I've opened a PR to centralize the header name : https://github.com/apache/camel/pull/14704

> Create a centralized variable for the header name CamelLangChain4jEmbeddingsVector
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-20634
>                 URL: https://issues.apache.org/jira/browse/CAMEL-20634
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-langchain4j
>    Affects Versions: 4.5.0
>            Reporter: Zineb Bendhiba
>            Assignee: Zineb Bendhiba
>            Priority: Minor
>             Fix For: 4.7.0
>
>
> While renaming the component (cf. https://issues.apache.org/jira/browse/CAMEL-20611), I had to change the header 'CamelLangChainEmbeddingsVector' to 'CamelLangChain4jEmbeddingsVector' three times: in 'langchain4j-embeddings', 'qdrant', and 'Milvus'.
> If we don't extract this string into a common dependency and need to rename it again, we will have to revisit multiple dependencies.
> Perhaps it would be better to move it to the 'camel-api' module.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)