You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Craig L. Ching (JIRA)" <ji...@apache.org> on 2008/06/06 22:48:45 UTC

[jira] Updated: (SLING-518) JCR-Explorer -- Add support for a "meta" selector to support richer information about node properties

     [ https://issues.apache.org/jira/browse/SLING-518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig L. Ching updated SLING-518:
---------------------------------

    Attachment: SLING-518-001.patch

Patch for functionality described in comment 1.

> JCR-Explorer -- Add support for a "meta" selector to support richer information about node properties
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SLING-518
>                 URL: https://issues.apache.org/jira/browse/SLING-518
>             Project: Sling
>          Issue Type: New Feature
>          Components: Commons JSON, Servlets Get
>            Reporter: Craig L. Ching
>            Priority: Minor
>         Attachments: SLING-518-001.patch
>
>
> This is the first patch for the JCR Explorer functionality, I'll continue to prepend "JCR-Explorer" to related JIRA issues.  This implements a new JSON rendering needed by the JCR Explorer.
> I'd originally asked to enhance the existing JSON interfaces to the repository to provide the JCR node properties as JSON objects rather than simple key/value pairs, but Alex suggested [1] that that would break existing operations and that I should create a new "metadata" selector to key the different rendering.
> That said, I'm not entirely thrilled about this patch.  It certainly works and was easy enough to create, however, it is mostly just a copy of the existing JsonItemWriter and maintaining two objects that are so similar is surely less than ideal.  But I didn't see an easy way to enhance the existing JsonItemWriter without fundamentally changing it.  So I'm just "throwing this over the wall" to get some feedback/suggestions on how best to proceed.
> I haven't implemented any tests for this, I'll see what I can whip up.  Hopefully there are already test cases for JsonItemWriter and JsonRendererServlet that I can base some tests on.
> Ideally, I'd like to get this functionality sorted out and committed before I submit the rest of the JCR Explorer implementation as the rest is non-intrusive and dependent on this.
> [1] -- http://mail-archives.apache.org/mod_mbox/incubator-sling-dev/200805.mbox/%3c63BEA5E623E09F4D92233FB12A9F794301FC85B7@emailmn.mqsoftware.com%3e
> NOTE: I'll attach a patch in the next comment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.