[jira] [Commented] (CAMEL-11446) Look at using awaitility in camel-core tests when we wait via thread sleep etc

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-11446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079537#comment-16079537 ] 

ASF GitHub Bot commented on CAMEL-11446:
----------------------------------------

GitHub user PascalSchumacher opened a pull request:

    https://github.com/apache/camel/pull/1809

    CAMEL-11446: Use awaitility in camel-core for testing where we otherw…

    …ise use thread sleep which can be speeded up.
    
    Great to see this getting done. :+1: 
    
    While looking at the code I noticed some places where is is possible to slightly reduce code by using additional awaitility features.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PascalSchumacher/camel awaitiblity_simplifications

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1809
    
----
commit 625147398da70388e40aea83f9a92877a94e3d1e
Author: Pascal Schumacher <pa...@gmx.net>
Date:   2017-07-09T10:33:49Z

    CAMEL-11446: Use awaitility in camel-core for testing where we otherwise use thread sleep which can be speeded up.
    
    slightly reduce code by using additional awaitility features

----


> Look at using awaitility in camel-core tests when we wait via thread sleep etc
> ------------------------------------------------------------------------------
>
>                 Key: CAMEL-11446
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11446
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core, tests
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: Future
>
>
> We can speedup some of the tests in camel-core by using
> https://github.com/awaitility/awaitility
> To wait for the condition before continuing. 
> We can also use NotifyBuilder which we do in some tests like, when there is only 1 message to wait for
> oneExchangeDone.matchesMockWaitTime();



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)