You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/01/08 05:41:15 UTC
[GitHub] zeppelin pull request #1869: [MINOR] fix: DON'T clean in npm run dev since u...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1869
[MINOR] fix: DON'T clean in npm run dev since useless
### What is this PR for?
Removed clean task in npm run dev because webpack-dev-server uses in-memory build :)
This was annoying since you have to build again after executing `npm run dev` which deleting the `zeppelin-web/dist` directory
### What type of PR is it?
[Bug Fix]
### Todos
Fixed at once
### What is the Jira issue?
MINOR
### How should this be tested?
1. Execute `npm run build && npm run dev`
2. Check whether`dist` directory exists or not
### Screenshots (if appropriate)
None
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/DON'T-clean-while-run-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1869
----
commit 79d876cb6408ae90644f179b1f28548f28927d6d
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-08T05:38:12Z
fix: DON'T clean in npm run dev
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1869: [MINOR] fix: DON'T clean in npm run dev cause it does ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1869
Thanks for comment @AhyoungRyu :)
Also, CI failed but irrelevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1869: [MINOR] fix: DON'T clean in npm run dev cause it does ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1869
LGTM and merge to master if no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1869: [MINOR] fix: DON'T clean in npm run dev since useless
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1869
\cc @Leemoonsoo for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1869: [MINOR] fix: DON'T clean in npm run dev cause i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1869
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1869: [MINOR] fix: DON'T clean in npm run dev cause it does ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1869
Yeah I removed this line in my local since I can't start debug mode in IntelliJ with `there is no zeppelin-web/dist` error.
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---