You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by karuppayya <gi...@git.apache.org> on 2017/06/10 12:16:31 UTC
[GitHub] zeppelin pull request #2403: ZEPPELIN-2637: Make useLegacySql configurable, ...
GitHub user karuppayya opened a pull request:
https://github.com/apache/zeppelin/pull/2403
ZEPPELIN-2637: Make useLegacySql configurable, in Bigquery Interpreter
### What is this PR for?
Make useLegacySql configurable, in Bigquery Interpreter
### What type of PR is it?
Improvement
### Todos - NA
* [ ] - Task
### What is the Jira issue?
ZEPPELIN-2637
### How should this be tested?
Set true/false for the property in interpreter setting and check the functionality.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NA
* Is there breaking changes for older versions? NA
* Does this needs documentation? NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuppayya/zeppelin ZEPPELIN-2637
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2403.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2403
----
commit d2263492b514d4ae91f48d6208199e749f297cb4
Author: Karup <ka...@qubole.com>
Date: 2017-05-27T10:31:09Z
Add use legacysql option
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2403: ZEPPELIN-2637: Make useLegacySql configurable, in Bigq...
Posted by karuppayya <gi...@git.apache.org>.
Github user karuppayya commented on the issue:
https://github.com/apache/zeppelin/pull/2403
@jongyoul CI failure looks to be not relevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2403: ZEPPELIN-2637: Make useLegacySql configurable, ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2403: ZEPPELIN-2637: Make useLegacySql configurable, in Bigq...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2403
@karuppayya Can you re-trigger the last profile of CI? https://travis-ci.org/karuppayya/zeppelin/builds/241501388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2403: ZEPPELIN-2637: Make useLegacySql configurable, in Bigq...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2403
Thanks. Merge it if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2403: ZEPPELIN-2637: Make useLegacySql configurable, in Bigq...
Posted by karuppayya <gi...@git.apache.org>.
Github user karuppayya commented on the issue:
https://github.com/apache/zeppelin/pull/2403
@jongyoul done. It passed this time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2403: ZEPPELIN-2637: Make useLegacySql configurable, in Bigq...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2403
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2403: ZEPPELIN-2637: Make useLegacySql configurable, in Bigq...
Posted by karuppayya <gi...@git.apache.org>.
Github user karuppayya commented on the issue:
https://github.com/apache/zeppelin/pull/2403
@jongyoul The error in bulld doesnt seem to be related to my change.
https://travis-ci.org/karuppayya/zeppelin/jobs/244000638
`Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//i[@uib-tooltip='WebSocket Connected']"}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---