[PR] fix isLatestVersion when field is missing [couchdb]

["rnewson (via GitHub)" <gi...@apache.org>]

rnewson opened a new pull request, #5955:
URL: https://github.com/apache/couchdb/pull/5955

   ## Overview
   
   When the request body contains no lucene_version field we expect nouveau to regard this as an attempt to create a Lucene index. isLatestVersion could fail as it didn't default correctly, leading to an ugly crash instead of a readable error.
   
   ## Testing recommendations
   
   covered by new test
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affect multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] This is my own work, I did not use AI, LLM's or similar technology
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] Documentation changes were made in the `src/docs` folder
   - [ ] Documentation changes were backported (separated PR) to affected branches
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix isLatestVersion when field is missing [couchdb]

["rnewson (via GitHub)" <gi...@apache.org>]

rnewson commented on PR #5955:
URL: https://github.com/apache/couchdb/pull/5955#issuecomment-4161257971

   Before the fix;
   
   ```shell
   curl http://foo:bar@localhost:5987/index/foo -XPUT -Huser-agent: -Hcontent-type:application/json -d '{"initial_purge_seq":0,"default_analyzer":"standard"}'
   {"code":500,"message":"There was an error processing your request. It has been logged (ID def4fc428b19cbbd)."}
   ```
   
   after;
   
   ``shell
   ➜  couchdb git:(main) curl http://foo:bar@localhost:5987/index/foo -XPUT -Huser-agent: -Hcontent-type:application/json -d '{"initial_purge_seq":0,"default_analyzer":"standard"}'
   {"code":400,"message":"Cannot create a new version 9 index"}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix isLatestVersion when field is missing [couchdb]

["rnewson (via GitHub)" <gi...@apache.org>]

rnewson merged PR #5955:
URL: https://github.com/apache/couchdb/pull/5955


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org