You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Riza Suminto (Jira)" <ji...@apache.org> on 2022/06/08 23:35:00 UTC
[jira] [Commented] (IMPALA-9614) Disable error logging for all re2 library usage.
[ https://issues.apache.org/jira/browse/IMPALA-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551870#comment-17551870 ]
Riza Suminto commented on IMPALA-9614:
--------------------------------------
Looks like we can tell re2 to not log error
https://github.com/google/re2/blob/3e9622e0cd94ebba6e04d5c50b7af32029e330d8/re2/re2.h#L686
> Disable error logging for all re2 library usage.
> ------------------------------------------------
>
> Key: IMPALA-9614
> URL: https://issues.apache.org/jira/browse/IMPALA-9614
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 3.4.0
> Reporter: Attila Jeges
> Priority: Major
>
> Impala uses the re2 library for a number of purposes:
> - Built-in functions : REGEXP_REPLACE, REGEXP_EXTRACT, REGEXP_LIKE
> - SQL operators: REGEXP, RLIKE, LIKE
> - Log and query redaction.
> Logging errors is disabled for REGEXP_REPLACE and REGEXP_EXTRACT built-in functions. In all other cases logging errors is enabled. Right now this behavior is hard-coded and not configurable. In case every row causes an error, this can be problematic as re2 errors will flood the impala error logs.
> We should disable error logging for all re2 library usage or make it configurable through an Impala startup flag.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org