You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/27 08:39:19 UTC
[GitHub] [shardingsphere] zjcnb opened a new pull request, #18629: Refactor readwrite-splitting api for yaml and boot-starter
zjcnb opened a new pull request, #18629:
URL: https://github.com/apache/shardingsphere/pull/18629
Fixes #18587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18629: Refactor readwrite-splitting api for yaml and boot-starter
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18629:
URL: https://github.com/apache/shardingsphere/pull/18629#issuecomment-1168240171
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18629](https://codecov.io/gh/apache/shardingsphere/pull/18629?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (afef3b7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b5070e7a0e66b8a36967f9d2a77a93a317c37b18?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5070e7) will **decrease** coverage by `0.01%`.
> The diff coverage is `60.21%`.
```diff
@@ Coverage Diff @@
## master #18629 +/- ##
============================================
- Coverage 59.41% 59.40% -0.02%
- Complexity 2259 2261 +2
============================================
Files 3727 3731 +4
Lines 54726 54766 +40
Branches 9313 9320 +7
============================================
+ Hits 32516 32534 +18
- Misses 19469 19485 +16
- Partials 2741 2747 +6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ynamicReadwriteSplittingStrategyConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2FwaS9zdHJhdGVneS9EeW5hbWljUmVhZHdyaXRlU3BsaXR0aW5nU3RyYXRlZ3lDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ng/factory/ReplicaLoadBalanceAlgorithmFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2ZhY3RvcnkvUmVwbGljYUxvYWRCYWxhbmNlQWxnb3JpdGhtRmFjdG9yeS5qYXZh) | `100.00% <ø> (ø)` | |
| [...ReadwriteSplittingDataSourceRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy95YW1sL2NvbmZpZy9ydWxlL1lhbWxSZWFkd3JpdGVTcGxpdHRpbmdEYXRhU291cmNlUnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ynamicReadwriteSplittingStrategyConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy95YW1sL2NvbmZpZy9zdHJhdGVneS9ZYW1sRHluYW1pY1JlYWR3cml0ZVNwbGl0dGluZ1N0cmF0ZWd5Q29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dwriteSplittingRuleConfigurationImportChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9jaGVja2VyL1JlYWR3cml0ZVNwbGl0dGluZ1J1bGVDb25maWd1cmF0aW9uSW1wb3J0Q2hlY2tlci5qYXZh) | `3.22% <0.00%> (-0.23%)` | :arrow_down: |
| [...tsql/rql/rule/RulesUsedResourceQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL3J1bGUvUnVsZXNVc2VkUmVzb3VyY2VRdWVyeVJlc3VsdFNldC5qYXZh) | `90.00% <50.00%> (-1.38%)` | :arrow_down: |
| [...riteSplittingStrategyConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy95YW1sL3N3YXBwZXIvc3RyYXRlZ3kvUmVhZHdyaXRlU3BsaXR0aW5nU3RyYXRlZ3lDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `52.17% <52.17%> (ø)` | |
| [...er/ReadwriteSplittingRuleBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9zcHJpbmcvbmFtZXNwYWNlL3BhcnNlci9SZWFkd3JpdGVTcGxpdHRpbmdSdWxlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `79.31% <62.50%> (-15.43%)` | :arrow_down: |
| [...ng/strategy/ReadwriteSplittingStrategyFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9zdHJhdGVneS9SZWFkd3JpdGVTcGxpdHRpbmdTdHJhdGVneUZhY3RvcnkuamF2YQ==) | `80.00% <75.00%> (-11.67%)` | :arrow_down: |
| [...rter/ReadwriteSplittingRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9kaXN0c3FsL2hhbmRsZXIvY29udmVydGVyL1JlYWR3cml0ZVNwbGl0dGluZ1J1bGVTdGF0ZW1lbnRDb252ZXJ0ZXIuamF2YQ==) | `87.50% <80.00%> (-2.50%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/shardingsphere/pull/18629/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18629?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18629?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a49ab8...afef3b7](https://codecov.io/gh/apache/shardingsphere/pull/18629?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a diff in pull request #18629: Refactor readwrite-splitting api
Posted by GitBox <gi...@apache.org>.
tristaZero commented on code in PR #18629:
URL: https://github.com/apache/shardingsphere/pull/18629#discussion_r908129855
##########
examples/shardingsphere-example-generator/src/main/resources/template/proxy/feature/readwrite-splitting.ftl:
##########
@@ -17,10 +17,12 @@
- !READWRITE_SPLITTING
dataSources:
readwrite_ds:
- type: Static
- props:
- write-data-source-name: write_ds
- read-data-source-names: read_ds_0, read_ds_1
+ dataSourceStrategy:
+ staticStrategy:
+ writeDataSourceName: write_ds
+ readDataSourceNames:
Review Comment:
```
- !READWRITE_SPLITTING
dataSources:
readwrite_ds:
staticStrategy:
writeDataSourceName: write_ds
readDataSourceNames:
- read_ds_0
- read_ds_1
loadBalancerName: read_balance
loadBalancers:
read_balance:
type: ROUND_ROBIN
```
##########
shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-api/src/main/java/org/apache/shardingsphere/readwritesplitting/api/strategy/ReadwriteSplittingStrategyConfiguration.java:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.readwritesplitting.api.strategy;
+
+/**
+ * Readwrite-splitting strategy configuration.
+ */
+public interface ReadwriteSplittingStrategyConfiguration {
+
Review Comment:
Blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a diff in pull request #18629: Refactor readwrite-splitting api
Posted by GitBox <gi...@apache.org>.
tristaZero commented on code in PR #18629:
URL: https://github.com/apache/shardingsphere/pull/18629#discussion_r908405448
##########
shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-core/src/main/java/org/apache/shardingsphere/readwritesplitting/yaml/config/strategy/YamlStaticReadwriteSplittingStrategyConfiguration.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.readwritesplitting.yaml.config.strategy;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.shardingsphere.infra.yaml.config.pojo.YamlConfiguration;
+
+import java.util.List;
+
+/**
+ * Static Readwrite-splitting strategy configuration for YAML.
+ */
+@Getter
+@Setter
+public class YamlStaticReadwriteSplittingStrategyConfiguration implements YamlConfiguration {
Review Comment:
final class?
##########
shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-spring/shardingsphere-readwrite-splitting-spring-namespace/src/main/java/org/apache/shardingsphere/readwritesplitting/spring/namespace/tag/strategy/DynamicReadwriteSplittingBeanDefinitionTag.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.readwritesplitting.spring.namespace.tag.strategy;
+
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+
+/**
+ * Readwrite-splitting Dynamic bean definition tag.
+ */
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public class DynamicReadwriteSplittingBeanDefinitionTag {
+
+ public static final String DYNAMIC_STRATEGY_ROOT_TAG = "dynamic-strategy";
+
+ public static final String AUTO_AWARE_DATA_SOURCE_NAME = "auto-aware-data-source-name";
+
+ public static final String WRITE_DATA_SOURCE_QUERY_ENABLED = "write-data-source-query-enabled";
Review Comment:
a props?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #18629: Refactor readwrite-splitting api
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #18629:
URL: https://github.com/apache/shardingsphere/pull/18629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on pull request #18629: Refactor readwrite-splitting api for yaml and boot-starter
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on PR #18629:
URL: https://github.com/apache/shardingsphere/pull/18629#issuecomment-1168159308
please fix CI first ^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on a diff in pull request #18629: Refactor readwrite-splitting api
Posted by GitBox <gi...@apache.org>.
zjcnb commented on code in PR #18629:
URL: https://github.com/apache/shardingsphere/pull/18629#discussion_r908343093
##########
examples/shardingsphere-example-generator/src/main/resources/template/proxy/feature/readwrite-splitting.ftl:
##########
@@ -17,10 +17,12 @@
- !READWRITE_SPLITTING
dataSources:
readwrite_ds:
- type: Static
- props:
- write-data-source-name: write_ds
- read-data-source-names: read_ds_0, read_ds_1
+ dataSourceStrategy:
+ staticStrategy:
+ writeDataSourceName: write_ds
+ readDataSourceNames:
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a diff in pull request #18629: Refactor readwrite-splitting api
Posted by GitBox <gi...@apache.org>.
tristaZero commented on code in PR #18629:
URL: https://github.com/apache/shardingsphere/pull/18629#discussion_r908129855
##########
examples/shardingsphere-example-generator/src/main/resources/template/proxy/feature/readwrite-splitting.ftl:
##########
@@ -17,10 +17,12 @@
- !READWRITE_SPLITTING
dataSources:
readwrite_ds:
- type: Static
- props:
- write-data-source-name: write_ds
- read-data-source-names: read_ds_0, read_ds_1
+ dataSourceStrategy:
+ staticStrategy:
+ writeDataSourceName: write_ds
+ readDataSourceNames:
Review Comment:
```
- !READWRITE_SPLITTING
dataSources:
readwrite_ds:
staticStrategy:
writeDataSourceName: write_ds
readDataSourceNames:
- read_ds_0
- read_ds_1
loadBalancerName: read_balance
loadBalancers:
read_balance:
type: ROUND_ROBIN
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org