You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/21 09:21:00 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31604: [SPARK-34487][K8S][TESTS] Use the runtime Hadoop version in K8s IT

HyukjinKwon commented on a change in pull request #31604:
URL: https://github.com/apache/spark/pull/31604#discussion_r579777511



##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala
##########
@@ -294,7 +295,7 @@ private[spark] trait DepsTestsSuite { k8sSuite: KubernetesSuite =>
       minioUrlStr: String): Unit = {
     val (minioHost, minioPort) = getServiceHostAndPort(minioUrlStr)
     val packages = if (Utils.isHadoop3) {
-      "org.apache.hadoop:hadoop-aws:3.2.0"
+      s"org.apache.hadoop:hadoop-aws:${VersionInfo.getVersion}"
     } else {
       "com.amazonaws:aws-java-sdk:1.7.4,org.apache.hadoop:hadoop-aws:2.7.6"

Review comment:
       I am reading https://github.com/apache/spark/commit/5e74570c8f5e7dfc1ca1c53c177827c5cea57bf1 and wonder if we can replace `2.7.6` -> `VersionInfo.getVersion` too.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org