You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Fernando (JIRA)" <ji...@apache.org> on 2008/12/09 21:19:44 UTC
[jira] Created: (TAP5-408) Inside Form.java, any changes to tracker
need to call setTracker, to update session object properly
Inside Form.java, any changes to tracker need to call setTracker, to update session object properly
---------------------------------------------------------------------------------------------------
Key: TAP5-408
URL: https://issues.apache.org/jira/browse/TAP5-408
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.17, 5.0.16, 5.0.15, 5.1.0.0, 5.1, 5.0.18
Reporter: Fernando
Priority: Critical
Attachments: form-session.diff
I talked about this on the mailing list. HttpSession objects have a requirement that if you dirty an object assigned to it, you have to call setAttribute again, to tell the app server the object has been modified.
Most of the code within Form.java does this properly ( whenever the tracker is modified, it calls setTracker, or _tracker = tracker, etc ).
It missed one spot, and this is a very small patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAP5-408) Inside Form.java, any changes to
tracker need to call setTracker, to update session object properly
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659861#action_12659861 ]
Howard M. Lewis Ship commented on TAP5-408:
-------------------------------------------
I think a better approach might be to change how Tapestry manages session-persistent values in general; much as ASOs are automatically re-stored into the session, we could have all kinds of session-persistent fields (i.e., @Persist("session")) restored ... with special cases for recognizing immutables and optimized objects (that track when they are dirty).
> Inside Form.java, any changes to tracker need to call setTracker, to update session object properly
> ---------------------------------------------------------------------------------------------------
>
> Key: TAP5-408
> URL: https://issues.apache.org/jira/browse/TAP5-408
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
> Reporter: Fernando
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Attachments: form-session.diff
>
>
> I talked about this on the mailing list. HttpSession objects have a requirement that if you dirty an object assigned to it, you have to call setAttribute again, to tell the app server the object has been modified.
> Most of the code within Form.java does this properly ( whenever the tracker is modified, it calls setTracker, or _tracker = tracker, etc ).
> It missed one spot, and this is a very small patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAP5-408) Objects that persist in the session
should automatically re-store themselves into the session at the end of the
request
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-408:
--------------------------------------
Summary: Objects that persist in the session should automatically re-store themselves into the session at the end of the request (was: Inside Form.java, any changes to tracker need to call setTracker, to update session object properly)
This is an expansion of the logic related to Application State Objects in 5.0; generalized to all objects that are stored in the Session.
There will be a new OptimizedSessionPeristentObject interface, and a @ImmutableSessionPersistedObject annotation.
> Objects that persist in the session should automatically re-store themselves into the session at the end of the request
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-408
> URL: https://issues.apache.org/jira/browse/TAP5-408
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
> Reporter: Fernando
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Attachments: form-session.diff
>
>
> I talked about this on the mailing list. HttpSession objects have a requirement that if you dirty an object assigned to it, you have to call setAttribute again, to tell the app server the object has been modified.
> Most of the code within Form.java does this properly ( whenever the tracker is modified, it calls setTracker, or _tracker = tracker, etc ).
> It missed one spot, and this is a very small patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAP5-408) Inside Form.java, any changes to tracker
need to call setTracker, to update session object properly
Posted by "Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fernando updated TAP5-408:
--------------------------
Attachment: form-session.diff
please apply this small patch.
> Inside Form.java, any changes to tracker need to call setTracker, to update session object properly
> ---------------------------------------------------------------------------------------------------
>
> Key: TAP5-408
> URL: https://issues.apache.org/jira/browse/TAP5-408
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
> Reporter: Fernando
> Priority: Critical
> Attachments: form-session.diff
>
>
> I talked about this on the mailing list. HttpSession objects have a requirement that if you dirty an object assigned to it, you have to call setAttribute again, to tell the app server the object has been modified.
> Most of the code within Form.java does this properly ( whenever the tracker is modified, it calls setTracker, or _tracker = tracker, etc ).
> It missed one spot, and this is a very small patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAP5-408) Objects that persist in the session
should automatically re-store themselves into the session at the end of the
request
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-408.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.1.0.0
> Objects that persist in the session should automatically re-store themselves into the session at the end of the request
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-408
> URL: https://issues.apache.org/jira/browse/TAP5-408
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
> Reporter: Fernando
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Fix For: 5.1.0.0
>
> Attachments: form-session.diff
>
>
> I talked about this on the mailing list. HttpSession objects have a requirement that if you dirty an object assigned to it, you have to call setAttribute again, to tell the app server the object has been modified.
> Most of the code within Form.java does this properly ( whenever the tracker is modified, it calls setTracker, or _tracker = tracker, etc ).
> It missed one spot, and this is a very small patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAP5-408) Inside Form.java, any changes to
tracker need to call setTracker, to update session object properly
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-408:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> Inside Form.java, any changes to tracker need to call setTracker, to update session object properly
> ---------------------------------------------------------------------------------------------------
>
> Key: TAP5-408
> URL: https://issues.apache.org/jira/browse/TAP5-408
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
> Reporter: Fernando
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Attachments: form-session.diff
>
>
> I talked about this on the mailing list. HttpSession objects have a requirement that if you dirty an object assigned to it, you have to call setAttribute again, to tell the app server the object has been modified.
> Most of the code within Form.java does this properly ( whenever the tracker is modified, it calls setTracker, or _tracker = tracker, etc ).
> It missed one spot, and this is a very small patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAP5-408) Inside Form.java, any changes to
tracker need to call setTracker, to update session object properly
Posted by "Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659871#action_12659871 ]
Fernando commented on TAP5-408:
-------------------------------
well, while we cook up the next version, can we apply this small patch to get it working for our distributed sessions? :) :)
but i would encourage the next version to try to only setAttribute if the object has been modified.. or else there would be performance penalties..
> Inside Form.java, any changes to tracker need to call setTracker, to update session object properly
> ---------------------------------------------------------------------------------------------------
>
> Key: TAP5-408
> URL: https://issues.apache.org/jira/browse/TAP5-408
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
> Reporter: Fernando
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Attachments: form-session.diff
>
>
> I talked about this on the mailing list. HttpSession objects have a requirement that if you dirty an object assigned to it, you have to call setAttribute again, to tell the app server the object has been modified.
> Most of the code within Form.java does this properly ( whenever the tracker is modified, it calls setTracker, or _tracker = tracker, etc ).
> It missed one spot, and this is a very small patch to fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org