[GitHub] [zookeeper] lvfangmin commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK

[GitBox <gi...@apache.org>]

lvfangmin commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK
URL: https://github.com/apache/zookeeper/pull/919#discussion_r305995160
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
 ##########
 @@ -378,8 +411,33 @@ public void operationComplete(Future<Channel> future) {
             }
         }
     }
+
+    @Sharable
+    static class ReadIssuedTrackingHandler extends ChannelDuplexHandler {
+
 
 Review comment:
   Currently, there is only a single instance of ReadIssuedTrackingHandler created in NettyServerCnxnFactory, and there is only a single instance of NettyServerCnxnFactory per JVM lifecycle, so ReadIssuedTrackingHandler is only 1 instance per JVM.
   
   Personally, I don't see there is value to create a static instance in ReadIssuedTrackingHandler, I'll keep the current implementation here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services