You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/13 15:01:08 UTC
[GitHub] [superset] prosdev0107 opened a new pull request, #19694: fix(db & connection): make to show/hide the password when only creating db connection
prosdev0107 opened a new pull request, #19694:
URL: https://github.com/apache/superset/pull/19694
### SUMMARY
Show/Hide Password in Database Connection Creation Dynamic Forms
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
![image](https://user-images.githubusercontent.com/47900232/163209969-34ede334-0ac0-4a4d-b4b9-a27dc587f576.png)
AFTER:
![Screen Shot 2022-04-13 at 7 53 46 AM](https://user-images.githubusercontent.com/47900232/163210067-f434d339-5c21-4cb2-b159-207f384b5e72.png)
![Screen Shot 2022-04-13 at 7 53 57 AM](https://user-images.githubusercontent.com/47900232/163210104-74541b8c-8443-4a38-bbd2-ab4314257066.png)
### TESTING INSTRUCTIONS
**Proposed changes:**
1. By default, anything typed in the password field should be masked
2. User should be able to toggle to see the password and toggle back to hiding the password ONLY WHEN entering the password when CONNECTING a database, not when EDITING one
3. When editing an existing db connection the password should be masked WITHOUT the option to show the password to prevent unintentionally showing passwords to someone who didn't initially connect the db
4. See details in comment on show/hide icon and tooltip text
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19694:
URL: https://github.com/apache/superset/pull/19694#issuecomment-1110310534
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a diff in pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on code in PR #19694:
URL: https://github.com/apache/superset/pull/19694#discussion_r849638572
##########
superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
import React from 'react';
-import { Input } from 'antd';
+import { Input, Tooltip } from 'antd';
Review Comment:
Hey I am sorry I was bugging and didn't realize this was the component itself. Sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19694:
URL: https://github.com/apache/superset/pull/19694#issuecomment-1100369436
@yousoph Ephemeral environment spinning up at http://35.88.99.67:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] prosdev0107 commented on a diff in pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
prosdev0107 commented on code in PR #19694:
URL: https://github.com/apache/superset/pull/19694#discussion_r849628208
##########
superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
import React from 'react';
-import { Input } from 'antd';
+import { Input, Tooltip } from 'antd';
Review Comment:
@AAfghahi
So you meant that we should create the PasswordInput superset component by splitting Input.password in `LabeledErrorBoundInput` component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #19694:
URL: https://github.com/apache/superset/pull/19694#issuecomment-1099466662
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #19694:
URL: https://github.com/apache/superset/pull/19694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19694:
URL: https://github.com/apache/superset/pull/19694#issuecomment-1099468189
@yousoph Ephemeral environment spinning up at http://35.166.83.249:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a diff in pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on code in PR #19694:
URL: https://github.com/apache/superset/pull/19694#discussion_r849606496
##########
superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
import React from 'react';
-import { Input } from 'antd';
+import { Input, Tooltip } from 'antd';
Review Comment:
Hey we actually should have superset versions of both of these as a superset component, there is a preference towards importing those. I think that might also be true for `EyeOutlined` and `EyeInvisibleOutlined`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19694:
URL: https://github.com/apache/superset/pull/19694#issuecomment-1109106777
# [Codecov](https://codecov.io/gh/apache/superset/pull/19694?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19694](https://codecov.io/gh/apache/superset/pull/19694?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b7de08) into [master](https://codecov.io/gh/apache/superset/commit/28742e5474b6b3ec5baa38b6bc0fb92adfcea9ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28742e5) will **increase** coverage by `0.00%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #19694 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 1692 1692
Lines 64802 64806 +4
Branches 6657 6659 +2
=======================================
+ Hits 43021 43024 +3
Misses 20081 20081
- Partials 1700 1701 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.25% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/src/components/Form/LabeledErrorBoundInput.tsx](https://codecov.io/gh/apache/superset/pull/19694/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybS9MYWJlbGVkRXJyb3JCb3VuZElucHV0LnRzeA==) | `95.00% <75.00%> (-5.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19694?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19694?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28742e5...4b7de08](https://codecov.io/gh/apache/superset/pull/19694?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] prosdev0107 commented on a diff in pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
prosdev0107 commented on code in PR #19694:
URL: https://github.com/apache/superset/pull/19694#discussion_r849628208
##########
superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
import React from 'react';
-import { Input } from 'antd';
+import { Input, Tooltip } from 'antd';
Review Comment:
@AAfghahi
So you mean that we should create the new PasswordInput superset component by splitting Password Input component in `LabeledErrorBoundInput` component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #19694: fix(db & connection): make to show/hide the password when only creating db connection
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #19694:
URL: https://github.com/apache/superset/pull/19694#issuecomment-1100365451
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org