You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/05 00:21:27 UTC
[GitHub] [ozone] avijayanhwx opened a new pull request #1993: HDDS-4902 Add Layout version information to Recon datanode info API.
avijayanhwx opened a new pull request #1993:
URL: https://github.com/apache/ozone/pull/1993
## What changes were proposed in this pull request?
Simple change to add Layout version information to Recon datanode info API.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4902
## How was this patch tested?
Manually tested.
Added unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] avijayanhwx commented on a change in pull request #1993: HDDS-4902 Add Layout version information to Recon datanode info API.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #1993:
URL: https://github.com/apache/ozone/pull/1993#discussion_r588556791
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/DatanodeMetadata.java
##########
@@ -67,6 +67,9 @@
@XmlElement(name = "buildDate")
private String buildDate;
+ @XmlElement(name = "layoutVersion")
Review comment:
You are correct, this was added as a Recon specific entity that may be formed by picking metadata pieces from multiple internal representations, and to support JAXB (I believe). We can revisit it and see if we can just reuse internal entities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] swagle commented on a change in pull request #1993: HDDS-4902 Add Layout version information to Recon datanode info API.
Posted by GitBox <gi...@apache.org>.
swagle commented on a change in pull request #1993:
URL: https://github.com/apache/ozone/pull/1993#discussion_r588547684
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/DatanodeMetadata.java
##########
@@ -67,6 +67,9 @@
@XmlElement(name = "buildDate")
private String buildDate;
+ @XmlElement(name = "layoutVersion")
Review comment:
General question: Why is this POJO class replicated inside recon vs having just one version in hdds-common or somewhere higher.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] swagle commented on a change in pull request #1993: HDDS-4902 Add Layout version information to Recon datanode info API.
Posted by GitBox <gi...@apache.org>.
swagle commented on a change in pull request #1993:
URL: https://github.com/apache/ozone/pull/1993#discussion_r588547684
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/DatanodeMetadata.java
##########
@@ -67,6 +67,9 @@
@XmlElement(name = "buildDate")
private String buildDate;
+ @XmlElement(name = "layoutVersion")
Review comment:
General question: Why is this POJO class replicated inside recon vs having just one version in hdds-common or somewhere higher vs extending it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] avijayanhwx commented on pull request #1993: HDDS-4902 Add Layout version information to Recon datanode info API.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1993:
URL: https://github.com/apache/ozone/pull/1993#issuecomment-792396613
Thanks for the review @swagle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] swagle commented on a change in pull request #1993: HDDS-4902 Add Layout version information to Recon datanode info API.
Posted by GitBox <gi...@apache.org>.
swagle commented on a change in pull request #1993:
URL: https://github.com/apache/ozone/pull/1993#discussion_r588546040
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -540,37 +540,35 @@ public void processLayoutVersionReport(DatanodeDetails datanodeDetails,
layoutVersionReport.toString().replaceAll("\n", "\\\\n"));
}
- if (layoutVersionReport != null) {
- int scmSlv = scmLayoutVersionManager.getSoftwareLayoutVersion();
- int scmMlv = scmLayoutVersionManager.getMetadataLayoutVersion();
- int dnSlv = layoutVersionReport.getSoftwareLayoutVersion();
- int dnMlv = layoutVersionReport.getMetadataLayoutVersion();
-
- // If the data node slv is > scm slv => log error condition
- if (dnSlv > scmSlv) {
- LOG.error("Rogue data node in the cluster : {}. " +
- "DataNode SoftwareLayoutVersion = {}, SCM " +
- "SoftwareLayoutVersion = {}",
- datanodeDetails.getHostName(), dnSlv, scmSlv);
- }
+ int scmSlv = scmLayoutVersionManager.getSoftwareLayoutVersion();
+ int scmMlv = scmLayoutVersionManager.getMetadataLayoutVersion();
+ int dnSlv = layoutVersionReport.getSoftwareLayoutVersion();
+ int dnMlv = layoutVersionReport.getMetadataLayoutVersion();
+
+ // If the data node slv is > scm slv => log error condition
+ if (dnSlv > scmSlv) {
+ LOG.error("Rogue data node in the cluster : {}. " +
Review comment:
Rouge is generally used in the security context, I'd suggest using Outdated or something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] avijayanhwx merged pull request #1993: HDDS-4902 Add Layout version information to Recon datanode info API.
Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #1993:
URL: https://github.com/apache/ozone/pull/1993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] swagle commented on a change in pull request #1993: HDDS-4902 Add Layout version information to Recon datanode info API.
Posted by GitBox <gi...@apache.org>.
swagle commented on a change in pull request #1993:
URL: https://github.com/apache/ozone/pull/1993#discussion_r588630781
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/DatanodeMetadata.java
##########
@@ -67,6 +67,9 @@
@XmlElement(name = "buildDate")
private String buildDate;
+ @XmlElement(name = "layoutVersion")
Review comment:
Make sense for another time but I think having all pojos in one place makes code so much more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org