You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/26 08:53:29 UTC
[GitHub] [skywalking-eyes] wu-sheng opened a new pull request #13: Fix strict is not working
wu-sheng opened a new pull request #13:
URL: https://github.com/apache/skywalking-eyes/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #13: Fix strict is not working
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #13:
URL: https://github.com/apache/skywalking-eyes/pull/13#discussion_r548966781
##########
File path: .asf.yaml
##########
@@ -28,3 +28,8 @@ github:
main:
required_status_checks:
strict: true
+ contexts:
+ - build-license-eye
+ required_pull_request_reviews:
+ dismiss_stale_reviews: true
+ required_approving_review_count: 1
Review comment:
Enabling "update branch" doesn't require reviews actually, it only requires checks to pass, which I agree to enable it, also with that enabled, no one can push to the master branch directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #13: Fix strict is not working
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #13:
URL: https://github.com/apache/skywalking-eyes/pull/13#discussion_r548966041
##########
File path: .asf.yaml
##########
@@ -28,3 +28,8 @@ github:
main:
required_status_checks:
strict: true
+ contexts:
+ - build-license-eye
Review comment:
What should put here? I thought it should be task name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 merged pull request #13: Fix strict is not working
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #13:
URL: https://github.com/apache/skywalking-eyes/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #13: Fix strict is not working
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #13:
URL: https://github.com/apache/skywalking-eyes/pull/13#discussion_r548965410
##########
File path: .asf.yaml
##########
@@ -28,3 +28,8 @@ github:
main:
required_status_checks:
strict: true
+ contexts:
+ - build-license-eye
+ required_pull_request_reviews:
+ dismiss_stale_reviews: true
+ required_approving_review_count: 1
Review comment:
I don't want to enable this in this repo.
https://github.com/apache/skywalking-python/pull/107#discussion_r548336881
We enabled it in the main repo because we faced problem that committer(s) merged the PRs too early, but in these repos where we have limited committers and I think we just leave it as is until we really need, so that some trivial changes can be merged as quickly as possible.
##########
File path: .asf.yaml
##########
@@ -28,3 +28,8 @@ github:
main:
required_status_checks:
strict: true
+ contexts:
+ - build-license-eye
Review comment:
This is not right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #13: Fix strict is not working
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #13:
URL: https://github.com/apache/skywalking-eyes/pull/13#discussion_r548961110
##########
File path: .asf.yaml
##########
@@ -28,3 +28,8 @@ github:
main:
required_status_checks:
strict: true
+ contexts:
+ - LicenseEye
Review comment:
@kezhenxu94 If no required task, the `strict: true` doesn't work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #13: Fix strict is not working
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #13:
URL: https://github.com/apache/skywalking-eyes/pull/13#discussion_r548965955
##########
File path: .asf.yaml
##########
@@ -28,3 +28,8 @@ github:
main:
required_status_checks:
strict: true
+ contexts:
+ - build-license-eye
+ required_pull_request_reviews:
+ dismiss_stale_reviews: true
+ required_approving_review_count: 1
Review comment:
Personally, I am not sure what is an trivial change. Mostly, you have more than one committer,they need to sync.
Reviewing doesn't have to be finding bug or code quality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org