You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2015/06/12 11:22:40 UTC
[GitHub] flink pull request: [release-0.9] [FLINK-2195] Configure Configura...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/828
[release-0.9] [FLINK-2195] Configure Configurable Hadoop InputFormats
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/incubator-flink configurable_if-2195-0.9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/828.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #828
----
commit c6da3eb868a6480019f91ccc0db4253f24b49f85
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-06-10T08:42:42Z
[FLINK-2195] Configure Configurable Hadoop InputFormats
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [release-0.9] [FLINK-2195] Configure Configura...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/828#issuecomment-111468533
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [release-0.9] [FLINK-2195] Configure Configura...
Posted by uce <gi...@git.apache.org>.
Github user uce closed the pull request at:
https://github.com/apache/flink/pull/828
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [release-0.9] [FLINK-2195] Configure Configura...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/828#discussion_r32303124
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopInputFormatBase.java ---
@@ -131,6 +136,11 @@ public BaseStatistics getStatistics(BaseStatistics cachedStats) throws IOExcepti
throw new RuntimeException(e);
}
+ // Configure input format for splits
+ if (mapreduceInputFormat instanceof Configurable) {
--- End diff --
I think this is not necessary, because the JM calls `configure()` before requesting InputSplits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [release-0.9] [FLINK-2195] Configure Configura...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/828#issuecomment-111431969
LGTM, except the one inline comment. Please check and remove if necessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---