[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3818: [ISSUE #3389] Replace Charset.forName() call with StandardCharsets.UTF_8

["Alonexc (via GitHub)" <gi...@apache.org>]

Alonexc commented on code in PR #3818:
URL: https://github.com/apache/eventmesh/pull/3818#discussion_r1178549036


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/constants/EventMeshConstants.java:
##########
@@ -31,7 +33,7 @@ public class EventMeshConstants {
 
     public static final String PROTOCOL_GRPC = "grpc";
 
-    public static final String DEFAULT_CHARSET = "UTF-8";
+    public static final String DEFAULT_CHARSET = StandardCharsets.UTF_8;

Review Comment:
   public static final String DEFAULT_CHARSET = StandardCharsets.UTF_8.name();
   or delete:
   ![image](https://user-images.githubusercontent.com/91315508/234739723-f4da2db6-231b-48b1-b02b-6e1d872702ce.png)
   
   Then replace it with `Constants.DEFAULT_CHARSET.name()`:
   
   In these classes need to be replaced:
   ![image](https://user-images.githubusercontent.com/91315508/234740195-f881ae5f-21ca-47e1-90db-4ca8b8cfc80d.png)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org