You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2023/03/17 22:53:15 UTC
[GitHub] [httpcomponents-client] arturobernalg opened a new pull request, #427: Add support for preamble and epilogue in multipart entities
arturobernalg opened a new pull request, #427:
URL: https://github.com/apache/httpcomponents-client/pull/427
This pull request adds support for preamble and epilogue in multipart entities for the Apache HttpComponents project. The `AbstractMultipartFormat` class has been updated to include `preamble` and `epilogue` as additional parameters in the constructor. The `HttpRFC6532Multipart`, `HttpRFC7578Multipart`, and `HttpStrictMultipart` classes have also been updated to support these parameters in their constructors.
Please let me know if there are any concerns or suggestions. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #427: Add support for preamble and epilogue in multipart entities
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #427:
URL: https://github.com/apache/httpcomponents-client/pull/427#issuecomment-1481183724
> > > @michael-o Does the change-set meet your expectations?
> >
> >
> > Yes, it does. But no testing valid input according to RFC. But I guess that is: shit in, shit out.
>
> Hey @michael-o Do i have to do any change/improvement? maybe some extra test? TY
No, this change is fine. Everything else I have mentioned here is beyond this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #427: Add support for preamble and epilogue in multipart entities
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c merged PR #427:
URL: https://github.com/apache/httpcomponents-client/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #427: Add support for preamble and epilogue in multipart entities
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #427:
URL: https://github.com/apache/httpcomponents-client/pull/427#issuecomment-1475215514
Is this one addressing https://issues.apache.org/jira/browse/HTTPCLIENT-2064?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] arturobernalg commented on a diff in pull request #427: Add support for preamble and epilogue in multipart entities
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on code in PR #427:
URL: https://github.com/apache/httpcomponents-client/pull/427#discussion_r1141355598
##########
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##########
@@ -245,20 +286,20 @@ MultipartFormEntity buildEntity() {
final AbstractMultipartFormat form;
switch (modeCopy) {
case LEGACY:
- form = new LegacyMultipart(charsetCopy, boundaryCopy, multipartPartsCopy);
+ form = new LegacyMultipart(charsetCopy, boundaryCopy, multipartPartsCopy, preamble, epilogue);
Review Comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #427: Add support for preamble and epilogue in multipart entities
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on code in PR #427:
URL: https://github.com/apache/httpcomponents-client/pull/427#discussion_r1141334925
##########
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##########
@@ -245,20 +286,20 @@ MultipartFormEntity buildEntity() {
final AbstractMultipartFormat form;
switch (modeCopy) {
case LEGACY:
- form = new LegacyMultipart(charsetCopy, boundaryCopy, multipartPartsCopy);
+ form = new LegacyMultipart(charsetCopy, boundaryCopy, multipartPartsCopy, preamble, epilogue);
Review Comment:
@arturobernalg Looks good to me. I would not add preamble and epilogue in the LEGACY mode, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #427: Add support for preamble and epilogue in multipart entities
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #427:
URL: https://github.com/apache/httpcomponents-client/pull/427#issuecomment-1475295597
> @michael-o Does the change-set meet your expectations?
Yes, it does. But no testing valid input according to RFC. But I guess that is: shit in, shit out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] arturobernalg commented on pull request #427: Add support for preamble and epilogue in multipart entities
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #427:
URL: https://github.com/apache/httpcomponents-client/pull/427#issuecomment-1481172228
> > @michael-o Does the change-set meet your expectations?
>
> Yes, it does. But no testing valid input according to RFC. But I guess that is: shit in, shit out.
Hey @michael-o
Do i have to do any change/improvement? maybe some test?
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org