[jira] [Commented] (KAFKA-4011) allow sizing RequestQueue in bytes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665144#comment-15665144 ] 

ASF GitHub Bot commented on KAFKA-4011:
---------------------------------------

Github user radai-rosenblatt closed the pull request at:

    https://github.com/apache/kafka/pull/1714


> allow sizing RequestQueue in bytes
> ----------------------------------
>
>                 Key: KAFKA-4011
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4011
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.10.0.0
>            Reporter: radai rosenblatt
>             Fix For: 0.10.2.0
>
>
> currently RequestChannel's requestQueue is sized in number of requests:
> {code:title=RequestChannel.scala|borderStyle=solid}
> private val requestQueue = new ArrayBlockingQueue[RequestChannel.Request](queueSize)
> {code}
> under the assumption that the end goal is a bound on server memory consumption, this requires the admin to know the avg request size.
> I would like to propose sizing the requestQueue not by number of requests, but by their accumulated size (Request.buffer.capacity). this would probably make configuring and sizing an instance easier.
> there would need to be a new configuration setting for this (queued.max.bytes?) - which could be either in addition to or instead of the current queued.max.requests setting



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)